Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c: designware-pci: Fix BUG_ON during device removal

Function i2c_dw_pci_remove() -> pci_free_irq_vectors() ->
pci_disable_msi() -> free_msi_irqs() will throw a BUG_ON() for MSI
enabled device since the driver has not released the requested IRQ before
calling the pci_free_irq_vectors().

Here driver requests an IRQ using devm_request_irq() but automatic
release happens only after remove callback. Fix this by explicitly
freeing the IRQ before calling pci_free_irq_vectors().

Fixes: 21aa3983d619 ("i2c: designware-pci: Switch over to MSI interrupts")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

authored by

Jarkko Nikula and committed by
Wolfram Sang
9be8bc4d 04bbb97d

+1
+1
drivers/i2c/busses/i2c-designware-pcidrv.c
··· 313 313 pm_runtime_get_noresume(&pdev->dev); 314 314 315 315 i2c_del_adapter(&dev->adapter); 316 + devm_free_irq(&pdev->dev, dev->irq, dev); 316 317 pci_free_irq_vectors(pdev); 317 318 } 318 319