Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[IA64] SKI Simulator boot

Sorry I didn't notice earlier, but that BUG_ON triggers for me on the
simulator. AFAICS the mask for itv is set in cpu_init(), which comes
after sal_init(). Consequently on the simulator the itv still has its
start value of zero. I've probably missed something, but I wonder why
at this stage of the boot you even need to save and restore the itv?

Signed-Off-By: Ian Wienand <ianw@gelato.unsw.edu.au>
Signed-off-by: Tony Luck <tony.luck@intel.com>

authored by

Ian Wienand and committed by
Tony Luck
9ba89334 f640f94e

+1 -5
+1 -5
arch/ia64/kernel/sal.c
··· 227 227 static void __init 228 228 check_sal_cache_flush (void) 229 229 { 230 - unsigned long flags, itv; 230 + unsigned long flags; 231 231 int cpu; 232 232 u64 vector; 233 233 ··· 238 238 * Schedule a timer interrupt, wait until it's reported, and see if 239 239 * SAL_CACHE_FLUSH drops it. 240 240 */ 241 - itv = ia64_get_itv(); 242 - BUG_ON((itv & (1 << 16)) == 0); 243 - 244 241 ia64_set_itv(IA64_TIMER_VECTOR); 245 242 ia64_set_itm(ia64_get_itc() + 1000); 246 243 ··· 257 260 ia64_eoi(); 258 261 } 259 262 260 - ia64_set_itv(itv); 261 263 local_irq_restore(flags); 262 264 put_cpu(); 263 265 }