Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Documentation: power: Use kcalloc() instead of kzalloc()

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, in the example code use the purpose specific kcalloc() function
instead of the argument size * count in the kzalloc() function.

At the same time, modify the translations accordingly.

Signed-off-by: Erick Archer <erick.archer@gmx.com>
Reviewed-by: Hu Haowen <2023002089@link.tyut.edu.cn>
Reviewed-by: Yanteng Si <siyanteng@loongson.cn>
Reviewed-by: Hu Haowen <2023002089@link.tyut.edu.cn>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

authored by

Erick Archer and committed by
Viresh Kumar
9ac3ebae 788715b5

+2 -2
+1 -1
Documentation/power/opp.rst
··· 305 305 { 306 306 /* Do things */ 307 307 num_available = dev_pm_opp_get_opp_count(dev); 308 - speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL); 308 + speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL); 309 309 /* populate the table in increasing order */ 310 310 freq = 0; 311 311 while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {
+1 -1
Documentation/translations/zh_CN/power/opp.rst
··· 274 274 { 275 275 /* 做一些事情 */ 276 276 num_available = dev_pm_opp_get_opp_count(dev); 277 - speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL); 277 + speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL); 278 278 /* 按升序填充表 */ 279 279 freq = 0; 280 280 while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {