Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: Goku-S: use helper functions to determine endpoint type and direction

Use helper functions to determine the type and direction of an endpoint
instead of fiddling with bEndpointAddress and bmAttributes

Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Matthias Kaehlcke and committed by
Greg Kroah-Hartman
9ab15651 81c8d8d2

+3 -3
+3 -3
drivers/usb/gadget/goku_udc.c
··· 110 110 return -EINVAL; 111 111 if (!dev->driver || dev->gadget.speed == USB_SPEED_UNKNOWN) 112 112 return -ESHUTDOWN; 113 - if (ep->num != (desc->bEndpointAddress & 0x0f)) 113 + if (ep->num != usb_endpoint_num(desc)) 114 114 return -EINVAL; 115 115 116 - switch (desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) { 116 + switch (usb_endpoint_type(desc)) { 117 117 case USB_ENDPOINT_XFER_BULK: 118 118 case USB_ENDPOINT_XFER_INT: 119 119 break; ··· 142 142 /* ep1/ep2 dma direction is chosen early; it works in the other 143 143 * direction, with pio. be cautious with out-dma. 144 144 */ 145 - ep->is_in = (USB_DIR_IN & desc->bEndpointAddress) != 0; 145 + ep->is_in = usb_endpoint_dir_in(desc); 146 146 if (ep->is_in) { 147 147 mode |= 1; 148 148 ep->dma = (use_dma != 0) && (ep->num == UDC_MSTRD_ENDPOINT);