Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i3c: master: svc: fix random hot join failure since timeout error

master side report:
silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000

BIT 20: TIMEOUT error
The module has stalled too long in a frame. This happens when:
- The TX FIFO or RX FIFO is not handled and the bus is stuck in the
middle of a message,
- No STOP was issued and between messages,
- IBI manual is used and no decision was made.
The maximum stall period is 100 μs.

This can be considered as being just a warning as the system IRQ latency
can easily be greater than 100us.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20231023161658.3890811-7-Frank.Li@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Frank Li and committed by
Alexandre Belloni
9aaeef11 dfd7cd6a

+9
+9
drivers/i3c/master/svc-i3c-master.c
··· 93 93 #define SVC_I3C_MINTMASKED 0x098 94 94 #define SVC_I3C_MERRWARN 0x09C 95 95 #define SVC_I3C_MERRWARN_NACK BIT(2) 96 + #define SVC_I3C_MERRWARN_TIMEOUT BIT(20) 96 97 #define SVC_I3C_MDMACTRL 0x0A0 97 98 #define SVC_I3C_MDATACTRL 0x0AC 98 99 #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) ··· 228 227 if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { 229 228 merrwarn = readl(master->regs + SVC_I3C_MERRWARN); 230 229 writel(merrwarn, master->regs + SVC_I3C_MERRWARN); 230 + 231 + /* Ignore timeout error */ 232 + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) { 233 + dev_dbg(master->dev, "Warning condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", 234 + mstatus, merrwarn); 235 + return false; 236 + } 237 + 231 238 dev_err(master->dev, 232 239 "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", 233 240 mstatus, merrwarn);