Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

thermal/drivers/devfreq_cooling: Fix wrong return on error path

The following error is reported by kbuild:

smatch warnings:
drivers/thermal/devfreq_cooling.c:433 of_devfreq_cooling_register_power() warn: passing zero to 'ERR_PTR'

Fix the error code by the setting the 'err' variable instead of 'cdev'.

Fixes: f8d354e821b2 ("thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210319202424.890968-1-daniel.lezcano@linaro.org

+1 -1
+1 -1
drivers/thermal/devfreq_cooling.c
··· 402 402 if (err < 0) 403 403 goto free_table; 404 404 405 - cdev = ERR_PTR(-ENOMEM); 405 + err = -ENOMEM; 406 406 name = kasprintf(GFP_KERNEL, "devfreq-%s", dev_name(dev)); 407 407 if (!name) 408 408 goto remove_qos_req;