tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

staging:iio:ad9852: Use spi_sync_transfer()

Use the spi_sync_transfer() helper function instead of open-coding it. Makes
the code a bit shorter.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

authored by

Lars-Peter Clausen and committed by
Jonathan Cameron 9aa698a0 63e4f052

+11 -34
+11 -34
drivers/staging/iio/frequency/ad9852.c
··· 67 67 const char *buf, 68 68 size_t len) 69 69 { 70 - struct spi_message msg; 71 70 struct spi_transfer xfer; 72 71 int ret; 73 72 struct ad9852_config *config = (struct ad9852_config *)buf; ··· 77 78 xfer.tx_buf = &config->phajst0[0]; 78 79 mutex_lock(&st->lock); 79 80 80 - spi_message_init(&msg); 81 - spi_message_add_tail(&xfer, &msg); 82 - ret = spi_sync(st->sdev, &msg); 81 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 83 82 if (ret) 84 83 goto error_ret; 85 84 86 85 xfer.len = 3; 87 86 xfer.tx_buf = &config->phajst1[0]; 88 87 89 - spi_message_init(&msg); 90 - spi_message_add_tail(&xfer, &msg); 91 - ret = spi_sync(st->sdev, &msg); 88 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 92 89 if (ret) 93 90 goto error_ret; 94 91 95 92 xfer.len = 6; 96 93 xfer.tx_buf = &config->fretun1[0]; 97 94 98 - spi_message_init(&msg); 99 - spi_message_add_tail(&xfer, &msg); 100 - ret = spi_sync(st->sdev, &msg); 95 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 101 96 if (ret) 102 97 goto error_ret; 103 98 104 99 xfer.len = 6; 105 100 xfer.tx_buf = &config->fretun2[0]; 106 101 107 - spi_message_init(&msg); 108 - spi_message_add_tail(&xfer, &msg); 109 - ret = spi_sync(st->sdev, &msg); 102 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 110 103 if (ret) 111 104 goto error_ret; 112 105 113 106 xfer.len = 6; 114 107 xfer.tx_buf = &config->dltafre[0]; 115 108 116 - spi_message_init(&msg); 117 - spi_message_add_tail(&xfer, &msg); 118 - ret = spi_sync(st->sdev, &msg); 109 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 119 110 if (ret) 120 111 goto error_ret; 121 112 122 113 xfer.len = 5; 123 114 xfer.tx_buf = &config->updtclk[0]; 124 115 125 - spi_message_init(&msg); 126 - spi_message_add_tail(&xfer, &msg); 127 - ret = spi_sync(st->sdev, &msg); 116 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 128 117 if (ret) 129 118 goto error_ret; 130 119 131 120 xfer.len = 4; 132 121 xfer.tx_buf = &config->ramprat[0]; 133 122 134 - spi_message_init(&msg); 135 - spi_message_add_tail(&xfer, &msg); 136 - ret = spi_sync(st->sdev, &msg); 123 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 137 124 if (ret) 138 125 goto error_ret; 139 126 140 127 xfer.len = 5; 141 128 xfer.tx_buf = &config->control[0]; 142 129 143 - spi_message_init(&msg); 144 - spi_message_add_tail(&xfer, &msg); 145 - ret = spi_sync(st->sdev, &msg); 130 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 146 131 if (ret) 147 132 goto error_ret; 148 133 149 134 xfer.len = 3; 150 135 xfer.tx_buf = &config->outpskm[0]; 151 136 152 - spi_message_init(&msg); 153 - spi_message_add_tail(&xfer, &msg); 154 - ret = spi_sync(st->sdev, &msg); 137 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 155 138 if (ret) 156 139 goto error_ret; 157 140 158 141 xfer.len = 2; 159 142 xfer.tx_buf = &config->outpskr[0]; 160 143 161 - spi_message_init(&msg); 162 - spi_message_add_tail(&xfer, &msg); 163 - ret = spi_sync(st->sdev, &msg); 144 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 164 145 if (ret) 165 146 goto error_ret; 166 147 167 148 xfer.len = 3; 168 149 xfer.tx_buf = &config->daccntl[0]; 169 150 170 - spi_message_init(&msg); 171 - spi_message_add_tail(&xfer, &msg); 172 - ret = spi_sync(st->sdev, &msg); 151 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 173 152 if (ret) 174 153 goto error_ret; 175 154 error_ret: