Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwspinlock: sprd: Use struct_size() helper in devm_kzalloc()

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.

Also, address the following sparse warnings:
drivers/hwspinlock/sprd_hwspinlock.c:96:36: warning: using sizeof on a flexible structure

Link: https://github.com/KSPP/linux/issues/174
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220125225723.GA78256@embeddedor

authored by

Gustavo A. R. Silva and committed by
Bjorn Andersson
9a413589 3e5f1ff7

+1 -2
+1 -2
drivers/hwspinlock/sprd_hwspinlock.c
··· 93 93 return -ENODEV; 94 94 95 95 sprd_hwlock = devm_kzalloc(&pdev->dev, 96 - sizeof(struct sprd_hwspinlock_dev) + 97 - SPRD_HWLOCKS_NUM * sizeof(*lock), 96 + struct_size(sprd_hwlock, bank.lock, SPRD_HWLOCKS_NUM), 98 97 GFP_KERNEL); 99 98 if (!sprd_hwlock) 100 99 return -ENOMEM;