Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

soundwire: cadence: adjust verbosity in response handling

There are too many logs on startup, e.g.

[ 8811.851497] cdns_fill_msg_resp: 2 callbacks suppressed
[ 8811.851497] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851498] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851499] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851499] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851500] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851500] intel-sdw intel-sdw.0: Msg Ack not received
[ 8811.851502] intel-sdw intel-sdw.0: Msg ignored for Slave 0
[ 8811.851503] soundwire sdw-master-0: No more devices to enumerate

We can skip the 'Msg Ack not received' since it's typical of the
enumeration end, and conversely add the information on which command
fails.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210115053738.22630-6-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Pierre-Louis Bossart and committed by
Vinod Koul
9a0c798c db9d9f94

+2 -2
+2 -2
drivers/soundwire/cadence_master.c
··· 483 483 for (i = 0; i < count; i++) { 484 484 if (!(cdns->response_buf[i] & CDNS_MCP_RESP_ACK)) { 485 485 no_ack = 1; 486 - dev_dbg_ratelimited(cdns->dev, "Msg Ack not received\n"); 486 + dev_vdbg(cdns->dev, "Msg Ack not received, cmd %d\n", i); 487 487 } 488 488 if (cdns->response_buf[i] & CDNS_MCP_RESP_NACK) { 489 489 nack = 1; 490 - dev_err_ratelimited(cdns->dev, "Msg NACK received\n"); 490 + dev_err_ratelimited(cdns->dev, "Msg NACK received, cmd %d\n", i); 491 491 } 492 492 } 493 493