Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/sstfb: Use fbdev I/O helpers

Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-41-tzimmermann@suse.de

+2 -6
+1 -3
drivers/video/fbdev/Kconfig
··· 1340 1340 tristate "3Dfx Voodoo Graphics (sst1) support" 1341 1341 depends on FB && PCI 1342 1342 depends on FB_DEVICE 1343 - select FB_CFB_FILLRECT 1344 - select FB_CFB_COPYAREA 1345 - select FB_CFB_IMAGEBLIT 1343 + select FB_IOMEM_HELPERS 1346 1344 select VIDEO_NOMODESET 1347 1345 help 1348 1346 Say Y here if you have a 3Dfx Voodoo Graphics (Voodoo1/sst1) or
+1 -3
drivers/video/fbdev/sstfb.c
··· 1310 1310 1311 1311 static const struct fb_ops sstfb_ops = { 1312 1312 .owner = THIS_MODULE, 1313 + FB_DEFAULT_IOMEM_OPS, 1313 1314 .fb_check_var = sstfb_check_var, 1314 1315 .fb_set_par = sstfb_set_par, 1315 1316 .fb_setcolreg = sstfb_setcolreg, 1316 - .fb_fillrect = cfb_fillrect, /* sstfb_fillrect */ 1317 - .fb_copyarea = cfb_copyarea, /* sstfb_copyarea */ 1318 - .fb_imageblit = cfb_imageblit, 1319 1317 .fb_ioctl = sstfb_ioctl, 1320 1318 }; 1321 1319