Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: max14577: Use devm_power_supply_register() helper

Use the device lifecycle managed register function. This helps prevent
mistakes like unregistering out of order in cleanup functions and
forgetting to unregister on error paths.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240129190246.73067-2-afd@ti.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Andrew Davis and committed by
Sebastian Reichel
99ae0756 4c5d387d

+3 -5
+3 -5
drivers/power/supply/max14577_charger.c
··· 586 586 } 587 587 588 588 psy_cfg.drv_data = chg; 589 - chg->charger = power_supply_register(&pdev->dev, &max14577_charger_desc, 590 - &psy_cfg); 589 + chg->charger = devm_power_supply_register(&pdev->dev, 590 + &max14577_charger_desc, 591 + &psy_cfg); 591 592 if (IS_ERR(chg->charger)) { 592 593 dev_err(&pdev->dev, "failed: power supply register\n"); 593 594 ret = PTR_ERR(chg->charger); ··· 609 608 610 609 static void max14577_charger_remove(struct platform_device *pdev) 611 610 { 612 - struct max14577_charger *chg = platform_get_drvdata(pdev); 613 - 614 611 device_remove_file(&pdev->dev, &dev_attr_fast_charge_timer); 615 - power_supply_unregister(chg->charger); 616 612 } 617 613 618 614 static const struct platform_device_id max14577_charger_id[] = {