Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: adp5588: get value from data out when dir is out

As discussed here: http://ez.analog.com/message/35852,
the 5587 revC and 5588 revB spec sheets contain a mistake
in the GPIO_DAT_STATx register description.

According to R.Shnell at ADI, as well as my own
observations, it should read:
"GPIO data status (shows GPIO state when read for inputs)".

This commit changes the get value function accordingly.

Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Jean-Francois Dagenais and committed by
Linus Walleij
992196f2 390d82e3

+13 -2
+13 -2
drivers/gpio/gpio-adp5588.c
··· 67 67 { 68 68 struct adp5588_gpio *dev = 69 69 container_of(chip, struct adp5588_gpio, gpio_chip); 70 + unsigned bank = ADP5588_BANK(off); 71 + unsigned bit = ADP5588_BIT(off); 72 + int val; 70 73 71 - return !!(adp5588_gpio_read(dev->client, 72 - GPIO_DAT_STAT1 + ADP5588_BANK(off)) & ADP5588_BIT(off)); 74 + mutex_lock(&dev->lock); 75 + 76 + if (dev->dir[bank] & bit) 77 + val = dev->dat_out[bank]; 78 + else 79 + val = adp5588_gpio_read(dev->client, GPIO_DAT_STAT1 + bank); 80 + 81 + mutex_unlock(&dev->lock); 82 + 83 + return !!(val & bit); 73 84 } 74 85 75 86 static void adp5588_gpio_set_value(struct gpio_chip *chip,