Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/vgem: drop DRIVER_PRIME (v2)

For actual sharing of buffers with other drivers (ie. actual hardware)
we'll need to pimp things out a bit better to deal w/ caching, multiple
memory domains, etc. See thread:

http://lists.freedesktop.org/archives/dri-devel/2015-May/083160.html

But for the llvmpipe use-case this isn't a problem. Nor do we really
need prime/dri3 (dri2 is sufficient). So until the other issues are
sorted lets remove DRIVER_PRIME.

v2: also drop the dead code

[airlied:
Okay I'm convinced this API could have a lot of use cases
that are really really bad, yes the upload use case is valid
however that isn't the only use case enabled, and if we allow
all the other use cases, people will start to (ab)use them,
and then they'll be ABI and my life will get worse, so disable
PRIME for now]

Acked-by: Thomas Hellstrom <thellstrom@vmware.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>

authored by

Rob Clark and committed by
Dave Airlie
990ed272 ba155e2d

+2 -116
+1 -1
drivers/gpu/drm/vgem/Makefile
··· 1 1 ccflags-y := -Iinclude/drm 2 - vgem-y := vgem_drv.o vgem_dma_buf.o 2 + vgem-y := vgem_drv.o 3 3 4 4 obj-$(CONFIG_DRM_VGEM) += vgem.o
-94
drivers/gpu/drm/vgem/vgem_dma_buf.c
··· 1 - /* 2 - * Copyright © 2012 Intel Corporation 3 - * Copyright © 2014 The Chromium OS Authors 4 - * 5 - * Permission is hereby granted, free of charge, to any person obtaining a 6 - * copy of this software and associated documentation files (the "Software"), 7 - * to deal in the Software without restriction, including without limitation 8 - * the rights to use, copy, modify, merge, publish, distribute, sublicense, 9 - * and/or sell copies of the Software, and to permit persons to whom the 10 - * Software is furnished to do so, subject to the following conditions: 11 - * 12 - * The above copyright notice and this permission notice (including the next 13 - * paragraph) shall be included in all copies or substantial portions of the 14 - * Software. 15 - * 16 - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 17 - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 18 - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL 19 - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 20 - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 21 - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS 22 - * IN THE SOFTWARE. 23 - * 24 - * Authors: 25 - * Ben Widawsky <ben@bwidawsk.net> 26 - * 27 - */ 28 - 29 - #include <linux/dma-buf.h> 30 - #include "vgem_drv.h" 31 - 32 - struct sg_table *vgem_gem_prime_get_sg_table(struct drm_gem_object *gobj) 33 - { 34 - struct drm_vgem_gem_object *obj = to_vgem_bo(gobj); 35 - BUG_ON(obj->pages == NULL); 36 - 37 - return drm_prime_pages_to_sg(obj->pages, obj->base.size / PAGE_SIZE); 38 - } 39 - 40 - int vgem_gem_prime_pin(struct drm_gem_object *gobj) 41 - { 42 - struct drm_vgem_gem_object *obj = to_vgem_bo(gobj); 43 - return vgem_gem_get_pages(obj); 44 - } 45 - 46 - void vgem_gem_prime_unpin(struct drm_gem_object *gobj) 47 - { 48 - struct drm_vgem_gem_object *obj = to_vgem_bo(gobj); 49 - vgem_gem_put_pages(obj); 50 - } 51 - 52 - void *vgem_gem_prime_vmap(struct drm_gem_object *gobj) 53 - { 54 - struct drm_vgem_gem_object *obj = to_vgem_bo(gobj); 55 - BUG_ON(obj->pages == NULL); 56 - 57 - return vmap(obj->pages, obj->base.size / PAGE_SIZE, 0, PAGE_KERNEL); 58 - } 59 - 60 - void vgem_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr) 61 - { 62 - vunmap(vaddr); 63 - } 64 - 65 - struct drm_gem_object *vgem_gem_prime_import(struct drm_device *dev, 66 - struct dma_buf *dma_buf) 67 - { 68 - struct drm_vgem_gem_object *obj = NULL; 69 - int ret; 70 - 71 - obj = kzalloc(sizeof(*obj), GFP_KERNEL); 72 - if (obj == NULL) { 73 - ret = -ENOMEM; 74 - goto fail; 75 - } 76 - 77 - ret = drm_gem_object_init(dev, &obj->base, dma_buf->size); 78 - if (ret) { 79 - ret = -ENOMEM; 80 - goto fail_free; 81 - } 82 - 83 - get_dma_buf(dma_buf); 84 - 85 - obj->base.dma_buf = dma_buf; 86 - obj->use_dma_buf = true; 87 - 88 - return &obj->base; 89 - 90 - fail_free: 91 - kfree(obj); 92 - fail: 93 - return ERR_PTR(ret); 94 - }
+1 -10
drivers/gpu/drm/vgem/vgem_drv.c
··· 302 302 }; 303 303 304 304 static struct drm_driver vgem_driver = { 305 - .driver_features = DRIVER_GEM | DRIVER_PRIME, 305 + .driver_features = DRIVER_GEM, 306 306 .gem_free_object = vgem_gem_free_object, 307 307 .gem_vm_ops = &vgem_gem_vm_ops, 308 308 .ioctls = vgem_ioctls, 309 309 .fops = &vgem_driver_fops, 310 310 .dumb_create = vgem_gem_dumb_create, 311 311 .dumb_map_offset = vgem_gem_dumb_map, 312 - .prime_handle_to_fd = drm_gem_prime_handle_to_fd, 313 - .prime_fd_to_handle = drm_gem_prime_fd_to_handle, 314 - .gem_prime_export = drm_gem_prime_export, 315 - .gem_prime_import = vgem_gem_prime_import, 316 - .gem_prime_pin = vgem_gem_prime_pin, 317 - .gem_prime_unpin = vgem_gem_prime_unpin, 318 - .gem_prime_get_sg_table = vgem_gem_prime_get_sg_table, 319 - .gem_prime_vmap = vgem_gem_prime_vmap, 320 - .gem_prime_vunmap = vgem_gem_prime_vunmap, 321 312 .name = DRIVER_NAME, 322 313 .desc = DRIVER_DESC, 323 314 .date = DRIVER_DATE,
-11
drivers/gpu/drm/vgem/vgem_drv.h
··· 43 43 extern void vgem_gem_put_pages(struct drm_vgem_gem_object *obj); 44 44 extern int vgem_gem_get_pages(struct drm_vgem_gem_object *obj); 45 45 46 - /* vgem_dma_buf.c */ 47 - extern struct sg_table *vgem_gem_prime_get_sg_table( 48 - struct drm_gem_object *gobj); 49 - extern int vgem_gem_prime_pin(struct drm_gem_object *gobj); 50 - extern void vgem_gem_prime_unpin(struct drm_gem_object *gobj); 51 - extern void *vgem_gem_prime_vmap(struct drm_gem_object *gobj); 52 - extern void vgem_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); 53 - extern struct drm_gem_object *vgem_gem_prime_import(struct drm_device *dev, 54 - struct dma_buf *dma_buf); 55 - 56 - 57 46 #endif