Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: atmel_usba_udc: Mask status with enabled irqs

Avoid interpreting useless status flags when we're not waiting for such
events by masking the status variable with the interrupt enabled register
value.

Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Reported-by: Patrice VILCHEZ <patrice.vilchez@atmel.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

authored by

Boris Brezillon and committed by
Felipe Balbi
9870d895 258e2ddd

+5 -1
+5 -1
drivers/usb/gadget/udc/atmel_usba_udc.c
··· 1612 1612 1613 1613 spin_lock(&udc->lock); 1614 1614 1615 - status = usba_readl(udc, INT_STA); 1615 + status = usba_readl(udc, INT_STA) & usba_readl(udc, INT_ENB); 1616 1616 DBG(DBG_INT, "irq, status=%#08x\n", status); 1617 1617 1618 1618 if (status & USBA_DET_SUSPEND) { 1619 1619 toggle_bias(udc, 0); 1620 1620 usba_writel(udc, INT_CLR, USBA_DET_SUSPEND); 1621 + usba_writel(udc, INT_ENB, 1622 + usba_readl(udc, INT_ENB) | USBA_WAKE_UP); 1621 1623 udc->bias_pulse_needed = true; 1622 1624 DBG(DBG_BUS, "Suspend detected\n"); 1623 1625 if (udc->gadget.speed != USB_SPEED_UNKNOWN ··· 1633 1631 if (status & USBA_WAKE_UP) { 1634 1632 toggle_bias(udc, 1); 1635 1633 usba_writel(udc, INT_CLR, USBA_WAKE_UP); 1634 + usba_writel(udc, INT_ENB, 1635 + usba_readl(udc, INT_ENB) & ~USBA_WAKE_UP); 1636 1636 DBG(DBG_BUS, "Wake Up CPU detected\n"); 1637 1637 } 1638 1638