Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: drop _mode_ from remaining connector functions

Since there's very few callers of these I've decided to do them all in
one patch. With this the unecessarily long drm_mode_connector_ prefix
is gone from the codebase! The only exception being struct
drm_mode_connector_set_property, which is part of the uapi so can't be
renamed.

Again done with sed+some manual fixups for indent issues.

Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180709084016.23750-8-daniel.vetter@ffwll.ch

+49 -50
+3 -3
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
··· 345 345 aconnector, connector->base.id, aconnector->mst_port); 346 346 347 347 aconnector->port = port; 348 - drm_mode_connector_set_path_property(connector, pathprop); 348 + drm_connector_set_path_property(connector, pathprop); 349 349 350 350 drm_connector_list_iter_end(&conn_iter); 351 351 aconnector->mst_connected = true; ··· 393 393 dev->mode_config.tile_property, 394 394 0); 395 395 396 - drm_mode_connector_set_path_property(connector, pathprop); 396 + drm_connector_set_path_property(connector, pathprop); 397 397 398 398 /* 399 399 * Initialize connector state before adding the connectror to drm and ··· 441 441 static void dm_dp_mst_link_status_reset(struct drm_connector *connector) 442 442 { 443 443 mutex_lock(&connector->dev->mode_config.mutex); 444 - drm_mode_connector_set_link_status_property(connector, DRM_MODE_LINK_STATUS_BAD); 444 + drm_connector_set_link_status_property(connector, DRM_MODE_LINK_STATUS_BAD); 445 445 mutex_unlock(&connector->dev->mode_config.mutex); 446 446 } 447 447
+1 -1
drivers/gpu/drm/drm_atomic_helper.c
··· 2867 2867 * resets the "link-status" property to GOOD, to force any link 2868 2868 * re-training. The SETCRTC ioctl does not define whether an update does 2869 2869 * need a full modeset or just a plane update, hence we're allowed to do 2870 - * that. See also drm_mode_connector_set_link_status_property(). 2870 + * that. See also drm_connector_set_link_status_property(). 2871 2871 * 2872 2872 * Returns: 2873 2873 * Returns 0 on success, negative errno numbers on failure.
+18 -18
drivers/gpu/drm/drm_connector.c
··· 852 852 * PATH: 853 853 * Connector path property to identify how this sink is physically 854 854 * connected. Used by DP MST. This should be set by calling 855 - * drm_mode_connector_set_path_property(), in the case of DP MST with the 855 + * drm_connector_set_path_property(), in the case of DP MST with the 856 856 * path property the MST manager created. Userspace cannot change this 857 857 * property. 858 858 * TILE: ··· 863 863 * are not gen-locked. Note that for tiled panels which are genlocked, like 864 864 * dual-link LVDS or dual-link DSI, the driver should try to not expose the 865 865 * tiling and virtualize both &drm_crtc and &drm_plane if needed. Drivers 866 - * should update this value using drm_mode_connector_set_tile_property(). 866 + * should update this value using drm_connector_set_tile_property(). 867 867 * Userspace cannot change this property. 868 868 * link-status: 869 869 * Connector link-status property to indicate the status of link. The 870 870 * default value of link-status is "GOOD". If something fails during or 871 871 * after modeset, the kernel driver may set this to "BAD" and issue a 872 872 * hotplug uevent. Drivers should update this value using 873 - * drm_mode_connector_set_link_status_property(). 873 + * drm_connector_set_link_status_property(). 874 874 * non_desktop: 875 875 * Indicates the output should be ignored for purposes of displaying a 876 876 * standard desktop environment or console. This is most likely because ··· 1425 1425 EXPORT_SYMBOL(drm_mode_create_suggested_offset_properties); 1426 1426 1427 1427 /** 1428 - * drm_mode_connector_set_path_property - set tile property on connector 1428 + * drm_connector_set_path_property - set tile property on connector 1429 1429 * @connector: connector to set property on. 1430 1430 * @path: path to use for property; must not be NULL. 1431 1431 * ··· 1437 1437 * Returns: 1438 1438 * Zero on success, negative errno on failure. 1439 1439 */ 1440 - int drm_mode_connector_set_path_property(struct drm_connector *connector, 1441 - const char *path) 1440 + int drm_connector_set_path_property(struct drm_connector *connector, 1441 + const char *path) 1442 1442 { 1443 1443 struct drm_device *dev = connector->dev; 1444 1444 int ret; ··· 1451 1451 dev->mode_config.path_property); 1452 1452 return ret; 1453 1453 } 1454 - EXPORT_SYMBOL(drm_mode_connector_set_path_property); 1454 + EXPORT_SYMBOL(drm_connector_set_path_property); 1455 1455 1456 1456 /** 1457 - * drm_mode_connector_set_tile_property - set tile property on connector 1457 + * drm_connector_set_tile_property - set tile property on connector 1458 1458 * @connector: connector to set property on. 1459 1459 * 1460 1460 * This looks up the tile information for a connector, and creates a ··· 1464 1464 * Returns: 1465 1465 * Zero on success, errno on failure. 1466 1466 */ 1467 - int drm_mode_connector_set_tile_property(struct drm_connector *connector) 1467 + int drm_connector_set_tile_property(struct drm_connector *connector) 1468 1468 { 1469 1469 struct drm_device *dev = connector->dev; 1470 1470 char tile[256]; ··· 1494 1494 dev->mode_config.tile_property); 1495 1495 return ret; 1496 1496 } 1497 - EXPORT_SYMBOL(drm_mode_connector_set_tile_property); 1497 + EXPORT_SYMBOL(drm_connector_set_tile_property); 1498 1498 1499 1499 /** 1500 1500 * drm_connector_update_edid_property - update the edid property of a connector ··· 1508 1508 * Zero on success, negative errno on failure. 1509 1509 */ 1510 1510 int drm_connector_update_edid_property(struct drm_connector *connector, 1511 - const struct edid *edid) 1511 + const struct edid *edid) 1512 1512 { 1513 1513 struct drm_device *dev = connector->dev; 1514 1514 size_t size = 0; ··· 1549 1549 EXPORT_SYMBOL(drm_connector_update_edid_property); 1550 1550 1551 1551 /** 1552 - * drm_mode_connector_set_link_status_property - Set link status property of a connector 1552 + * drm_connector_set_link_status_property - Set link status property of a connector 1553 1553 * @connector: drm connector 1554 1554 * @link_status: new value of link status property (0: Good, 1: Bad) 1555 1555 * ··· 1567 1567 * it is not limited to DP or link training. For example, if we implement 1568 1568 * asynchronous setcrtc, this property can be used to report any failures in that. 1569 1569 */ 1570 - void drm_mode_connector_set_link_status_property(struct drm_connector *connector, 1571 - uint64_t link_status) 1570 + void drm_connector_set_link_status_property(struct drm_connector *connector, 1571 + uint64_t link_status) 1572 1572 { 1573 1573 struct drm_device *dev = connector->dev; 1574 1574 ··· 1576 1576 connector->state->link_status = link_status; 1577 1577 drm_modeset_unlock(&dev->mode_config.connection_mutex); 1578 1578 } 1579 - EXPORT_SYMBOL(drm_mode_connector_set_link_status_property); 1579 + EXPORT_SYMBOL(drm_connector_set_link_status_property); 1580 1580 1581 1581 /** 1582 1582 * drm_connector_init_panel_orientation_property - ··· 1629 1629 } 1630 1630 EXPORT_SYMBOL(drm_connector_init_panel_orientation_property); 1631 1631 1632 - int drm_mode_connector_set_obj_prop(struct drm_mode_object *obj, 1632 + int drm_connector_set_obj_prop(struct drm_mode_object *obj, 1633 1633 struct drm_property *property, 1634 1634 uint64_t value) 1635 1635 { ··· 1647 1647 return ret; 1648 1648 } 1649 1649 1650 - int drm_mode_connector_property_set_ioctl(struct drm_device *dev, 1651 - void *data, struct drm_file *file_priv) 1650 + int drm_connector_property_set_ioctl(struct drm_device *dev, 1651 + void *data, struct drm_file *file_priv) 1652 1652 { 1653 1653 struct drm_mode_connector_set_property *conn_set_prop = data; 1654 1654 struct drm_mode_obj_set_property obj_set_prop = {
+3 -3
drivers/gpu/drm/drm_crtc_internal.h
··· 148 148 void drm_connector_ida_destroy(void); 149 149 void drm_connector_unregister_all(struct drm_device *dev); 150 150 int drm_connector_register_all(struct drm_device *dev); 151 - int drm_mode_connector_set_obj_prop(struct drm_mode_object *obj, 151 + int drm_connector_set_obj_prop(struct drm_mode_object *obj, 152 152 struct drm_property *property, 153 153 uint64_t value); 154 154 int drm_connector_create_standard_properties(struct drm_device *dev); ··· 156 156 void drm_connector_free_work_fn(struct work_struct *work); 157 157 158 158 /* IOCTL */ 159 - int drm_mode_connector_property_set_ioctl(struct drm_device *dev, 160 - void *data, struct drm_file *file_priv); 159 + int drm_connector_property_set_ioctl(struct drm_device *dev, 160 + void *data, struct drm_file *file_priv); 161 161 int drm_mode_getconnector(struct drm_device *dev, 162 162 void *data, struct drm_file *file_priv); 163 163
+2 -2
drivers/gpu/drm/drm_dp_mst_topology.c
··· 1215 1215 port->pdt == DP_PEER_DEVICE_SST_SINK) && 1216 1216 port->port_num >= DP_MST_LOGICAL_PORT_0) { 1217 1217 port->cached_edid = drm_get_edid(port->connector, &port->aux.ddc); 1218 - drm_mode_connector_set_tile_property(port->connector); 1218 + drm_connector_set_tile_property(port->connector); 1219 1219 } 1220 1220 (*mstb->mgr->cbs->register_connector)(port->connector); 1221 1221 } ··· 2559 2559 edid = drm_edid_duplicate(port->cached_edid); 2560 2560 else { 2561 2561 edid = drm_get_edid(connector, &port->aux.ddc); 2562 - drm_mode_connector_set_tile_property(connector); 2562 + drm_connector_set_tile_property(connector); 2563 2563 } 2564 2564 port->has_audio = drm_detect_monitor_audio(edid); 2565 2565 drm_dp_put_port(port);
+1 -1
drivers/gpu/drm/drm_ioctl.c
··· 641 641 DRM_IOCTL_DEF(DRM_IOCTL_MODE_ATTACHMODE, drm_noop, DRM_MASTER|DRM_UNLOCKED), 642 642 DRM_IOCTL_DEF(DRM_IOCTL_MODE_DETACHMODE, drm_noop, DRM_MASTER|DRM_UNLOCKED), 643 643 DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETPROPERTY, drm_mode_getproperty_ioctl, DRM_UNLOCKED), 644 - DRM_IOCTL_DEF(DRM_IOCTL_MODE_SETPROPERTY, drm_mode_connector_property_set_ioctl, DRM_MASTER|DRM_UNLOCKED), 644 + DRM_IOCTL_DEF(DRM_IOCTL_MODE_SETPROPERTY, drm_connector_property_set_ioctl, DRM_MASTER|DRM_UNLOCKED), 645 645 DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETPROPBLOB, drm_mode_getblob_ioctl, DRM_UNLOCKED), 646 646 DRM_IOCTL_DEF(DRM_IOCTL_MODE_GETFB, drm_mode_getfb, DRM_UNLOCKED), 647 647 DRM_IOCTL_DEF(DRM_IOCTL_MODE_ADDFB, drm_mode_addfb_ioctl, DRM_UNLOCKED),
+1 -2
drivers/gpu/drm/drm_mode_object.c
··· 433 433 drm_modeset_lock_all(dev); 434 434 switch (obj->type) { 435 435 case DRM_MODE_OBJECT_CONNECTOR: 436 - ret = drm_mode_connector_set_obj_prop(obj, prop, 437 - prop_value); 436 + ret = drm_connector_set_obj_prop(obj, prop, prop_value); 438 437 break; 439 438 case DRM_MODE_OBJECT_CRTC: 440 439 ret = drm_mode_crtc_set_obj_prop(obj, prop, prop_value);
+3 -3
drivers/gpu/drm/drm_modes.c
··· 1353 1353 EXPORT_SYMBOL(drm_mode_sort); 1354 1354 1355 1355 /** 1356 - * drm_mode_connector_list_update - update the mode list for the connector 1356 + * drm_connector_list_update - update the mode list for the connector 1357 1357 * @connector: the connector to update 1358 1358 * 1359 1359 * This moves the modes from the @connector probed_modes list ··· 1363 1363 * This is just a helper functions doesn't validate any modes itself and also 1364 1364 * doesn't prune any invalid modes. Callers need to do that themselves. 1365 1365 */ 1366 - void drm_mode_connector_list_update(struct drm_connector *connector) 1366 + void drm_connector_list_update(struct drm_connector *connector) 1367 1367 { 1368 1368 struct drm_display_mode *pmode, *pt; 1369 1369 ··· 1412 1412 } 1413 1413 } 1414 1414 } 1415 - EXPORT_SYMBOL(drm_mode_connector_list_update); 1415 + EXPORT_SYMBOL(drm_connector_list_update); 1416 1416 1417 1417 /** 1418 1418 * drm_mode_parse_command_line_for_connector - parse command line modeline for connector
+2 -2
drivers/gpu/drm/drm_probe_helper.c
··· 360 360 * using the VESA GTF/CVT formulas. 361 361 * 362 362 * 3. Modes are moved from the probed_modes list to the modes list. Potential 363 - * duplicates are merged together (see drm_mode_connector_list_update()). 363 + * duplicates are merged together (see drm_connector_list_update()). 364 364 * After this step the probed_modes list will be empty again. 365 365 * 366 366 * 4. Any non-stale mode on the modes list then undergoes validation ··· 485 485 if (count == 0) 486 486 goto prune; 487 487 488 - drm_mode_connector_list_update(connector); 488 + drm_connector_list_update(connector); 489 489 490 490 if (connector->interlace_allowed) 491 491 mode_flags |= DRM_MODE_FLAG_INTERLACE;
+2 -2
drivers/gpu/drm/i915/intel_dp.c
··· 6320 6320 /* Set connector link status to BAD and send a Uevent to notify 6321 6321 * userspace to do a modeset. 6322 6322 */ 6323 - drm_mode_connector_set_link_status_property(connector, 6324 - DRM_MODE_LINK_STATUS_BAD); 6323 + drm_connector_set_link_status_property(connector, 6324 + DRM_MODE_LINK_STATUS_BAD); 6325 6325 mutex_unlock(&connector->dev->mode_config.mutex); 6326 6326 /* Send Hotplug uevent so userspace can reprobe */ 6327 6327 drm_kms_helper_hotplug_event(connector->dev);
+1 -1
drivers/gpu/drm/i915/intel_dp_mst.c
··· 474 474 drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0); 475 475 drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0); 476 476 477 - ret = drm_mode_connector_set_path_property(connector, pathprop); 477 + ret = drm_connector_set_path_property(connector, pathprop); 478 478 if (ret) 479 479 goto err; 480 480
+1 -1
drivers/gpu/drm/msm/dsi/dsi_manager.c
··· 393 393 ret = dsi_dual_connector_tile_init(connector, id); 394 394 if (ret) 395 395 return ret; 396 - ret = drm_mode_connector_set_tile_property(connector); 396 + ret = drm_connector_set_tile_property(connector); 397 397 if (ret) { 398 398 pr_err("%s: set tile property failed, %d\n", 399 399 __func__, ret);
+1 -1
drivers/gpu/drm/nouveau/dispnv50/disp.c
··· 931 931 932 932 drm_object_attach_property(&mstc->connector.base, dev->mode_config.path_property, 0); 933 933 drm_object_attach_property(&mstc->connector.base, dev->mode_config.tile_property, 0); 934 - drm_mode_connector_set_path_property(&mstc->connector, path); 934 + drm_connector_set_path_property(&mstc->connector, path); 935 935 return 0; 936 936 } 937 937
+1 -1
drivers/gpu/drm/radeon/radeon_dp_mst.c
··· 290 290 291 291 drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0); 292 292 drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0); 293 - drm_mode_connector_set_path_property(connector, pathprop); 293 + drm_connector_set_path_property(connector, pathprop); 294 294 295 295 return connector; 296 296 }
+1 -1
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
··· 2114 2114 drm_mode_probed_add(connector, mode); 2115 2115 } 2116 2116 2117 - drm_mode_connector_list_update(connector); 2117 + drm_connector_list_update(connector); 2118 2118 /* Move the prefered mode first, help apps pick the right mode. */ 2119 2119 drm_mode_sort(&connector->modes); 2120 2120
+7 -7
include/drm/drm_connector.h
··· 919 919 * @path_blob_ptr: 920 920 * 921 921 * DRM blob property data for the DP MST path property. This should only 922 - * be updated by calling drm_mode_connector_set_path_property(). 922 + * be updated by calling drm_connector_set_path_property(). 923 923 */ 924 924 struct drm_property_blob *path_blob_ptr; 925 925 ··· 1046 1046 * the tiling and virtualize both &drm_crtc and &drm_plane if needed. 1047 1047 * 1048 1048 * This should only be updated by calling 1049 - * drm_mode_connector_set_tile_property(). 1049 + * drm_connector_set_tile_property(). 1050 1050 */ 1051 1051 struct drm_property_blob *tile_blob_ptr; 1052 1052 ··· 1191 1191 1192 1192 int drm_mode_create_suggested_offset_properties(struct drm_device *dev); 1193 1193 1194 - int drm_mode_connector_set_path_property(struct drm_connector *connector, 1195 - const char *path); 1196 - int drm_mode_connector_set_tile_property(struct drm_connector *connector); 1194 + int drm_connector_set_path_property(struct drm_connector *connector, 1195 + const char *path); 1196 + int drm_connector_set_tile_property(struct drm_connector *connector); 1197 1197 int drm_connector_update_edid_property(struct drm_connector *connector, 1198 1198 const struct edid *edid); 1199 - void drm_mode_connector_set_link_status_property(struct drm_connector *connector, 1200 - uint64_t link_status); 1199 + void drm_connector_set_link_status_property(struct drm_connector *connector, 1200 + uint64_t link_status); 1201 1201 int drm_connector_init_panel_orientation_property( 1202 1202 struct drm_connector *connector, int width, int height); 1203 1203
+1 -1
include/drm/drm_modes.h
··· 530 530 void drm_mode_prune_invalid(struct drm_device *dev, 531 531 struct list_head *mode_list, bool verbose); 532 532 void drm_mode_sort(struct list_head *mode_list); 533 - void drm_mode_connector_list_update(struct drm_connector *connector); 533 + void drm_connector_list_update(struct drm_connector *connector); 534 534 535 535 /* parsing cmdline modes */ 536 536 bool