Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ubi: Add a check for ubi_num

Added a check for ubi_num for negative numbers
If the variable ubi_num takes negative values then we get:

qemu-system-arm ... -append "ubi.mtd=0,0,0,-22222345" ...
[ 0.745065] ubi_attach_mtd_dev from ubi_init+0x178/0x218
[ 0.745230] ubi_init from do_one_initcall+0x70/0x1ac
[ 0.745344] do_one_initcall from kernel_init_freeable+0x198/0x224
[ 0.745474] kernel_init_freeable from kernel_init+0x18/0x134
[ 0.745600] kernel_init from ret_from_fork+0x14/0x28
[ 0.745727] Exception stack(0x90015fb0 to 0x90015ff8)

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 83ff59a06663 ("UBI: support ubi_num on mtd.ubi command line")
Cc: stable@vger.kernel.org
Signed-off-by: Denis Arefev <arefev@swemel.ru>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

authored by

Denis Arefev and committed by
Richard Weinberger
97bbf9e3 9d895519

+1 -1
+1 -1
drivers/mtd/ubi/build.c
··· 1537 1537 if (token) { 1538 1538 int err = kstrtoint(token, 10, &p->ubi_num); 1539 1539 1540 - if (err) { 1540 + if (err || p->ubi_num < UBI_DEV_NUM_AUTO) { 1541 1541 pr_err("UBI error: bad value for ubi_num parameter: %s\n", 1542 1542 token); 1543 1543 return -EINVAL;