PCI: add D3 power state avoidance quirk

Libata has some hacks to deal with certain controllers going silly in D3
state. The right way to handle this is to keep a PCI device flag for
such devices. That can then be generalised for no ATA devices with power
problems.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

authored by Alan Cox and committed by Jesse Barnes 979b1791 362b7077

+19
+4
drivers/pci/pci.c
··· 572 572 if (!ret) 573 573 pci_update_current_state(dev); 574 574 } 575 + /* This device is quirked not to be put into D3, so 576 + don't put it in D3 */ 577 + if (state == PCI_D3hot && (dev->dev_flags & PCI_DEV_FLAGS_NO_D3)) 578 + return 0; 575 579 576 580 error = pci_raw_set_power_state(dev, state); 577 581
+13
drivers/pci/quirks.c
··· 923 923 } 924 924 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801CA_10, quirk_ide_samemode); 925 925 926 + /* 927 + * Some ATA devices break if put into D3 928 + */ 929 + 930 + static void __devinit quirk_no_ata_d3(struct pci_dev *pdev) 931 + { 932 + /* Quirk the legacy ATA devices only. The AHCI ones are ok */ 933 + if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) 934 + pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3; 935 + } 936 + DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, PCI_ANY_ID, quirk_no_ata_d3); 937 + DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_ATI, PCI_ANY_ID, quirk_no_ata_d3); 938 + 926 939 /* This was originally an Alpha specific thing, but it really fits here. 927 940 * The i82375 PCI/EISA bridge appears as non-classified. Fix that. 928 941 */
+2
include/linux/pci.h
··· 124 124 * generation too. 125 125 */ 126 126 PCI_DEV_FLAGS_MSI_INTX_DISABLE_BUG = (__force pci_dev_flags_t) 1, 127 + /* Device configuration is irrevocably lost if disabled into D3 */ 128 + PCI_DEV_FLAGS_NO_D3 = (__force pci_dev_flags_t) 2, 127 129 }; 128 130 129 131 typedef unsigned short __bitwise pci_bus_flags_t;