Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

During the initial setup of a logical channel, it is necessary to unmask
the GIM in order to receive generated terminal count and error interrupts.
We're separating out this required code so it will be possible to move
the remaining code in d40_phy_cfg(), which is mostly runtime configuration
into the runtime_config() routine.

Cc: Dan Williams <djbw@fb.com>
Cc: Per Forlin <per.forlin@stericsson.com>
Cc: Rabin Vincent <rabin@rab.in>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Lee Jones and committed by
Linus Walleij
9778256b 252f27b0

+4 -5
+4
drivers/dma/ste_dma40.c
··· 2513 2513 d40c->lcpa = d40c->base->lcpa_base + 2514 2514 d40c->dma_cfg.dev_type * 2515 2515 D40_LCPA_CHAN_SIZE + D40_LCPA_CHAN_DST_DELTA; 2516 + 2517 + /* Unmask the Global Interrupt Mask. */ 2518 + d40c->src_def_cfg |= BIT(D40_SREG_CFG_LOG_GIM_POS); 2519 + d40c->dst_def_cfg |= BIT(D40_SREG_CFG_LOG_GIM_POS); 2516 2520 } 2517 2521 2518 2522 dev_dbg(chan2dev(d40c), "allocated %s channel (phy %d%s)\n",
-5
drivers/dma/ste_dma40_ll.c
··· 107 107 src |= 1 << D40_SREG_CFG_PRI_POS; 108 108 dst |= 1 << D40_SREG_CFG_PRI_POS; 109 109 } 110 - 111 - } else { 112 - /* Logical channel */ 113 - dst |= 1 << D40_SREG_CFG_LOG_GIM_POS; 114 - src |= 1 << D40_SREG_CFG_LOG_GIM_POS; 115 110 } 116 111 117 112 if (cfg->src_info.big_endian)