Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

af_unix: optimize unix_dgram_poll()

unix_dgram_poll() is pretty expensive to check POLLOUT status, because
it has to lock the socket to get its peer, take a reference on the peer
to check its receive queue status, and queue another poll_wait on
peer_wait. This all can be avoided if the process calling
unix_dgram_poll() is not interested in POLLOUT status. It makes
unix_dgram_recvmsg() faster by not queueing irrelevant pollers in
peer_wait.

On a test program provided by Alan Crequy :

Before:

real 0m0.211s
user 0m0.000s
sys 0m0.208s

After:

real 0m0.044s
user 0m0.000s
sys 0m0.040s

Suggested-by: Davide Libenzi <davidel@xmailserver.org>
Reported-by: Alban Crequy <alban.crequy@collabora.co.uk>
Acked-by: Davide Libenzi <davidel@xmailserver.org>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Eric Dumazet and committed by
David S. Miller
973a34aa 5456f09a

+4
+4
net/unix/af_unix.c
··· 2091 2091 return mask; 2092 2092 } 2093 2093 2094 + /* No write status requested, avoid expensive OUT tests. */ 2095 + if (wait && !(wait->key & (POLLWRBAND | POLLWRNORM | POLLOUT))) 2096 + return mask; 2097 + 2094 2098 writable = unix_writable(sk); 2095 2099 other = unix_peer_get(sk); 2096 2100 if (other) {