Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Hibernation: Mark SNAPSHOT_SET_SWAP_FILE ioctl as deprecated (rev. 2)

Mark the SNAPSHOT_SET_SWAP_FILE ioctl belonging to the hibernation userland
interface as deprecated.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Len Brown <len.brown@intel.com>

authored by

Rafael J. Wysocki and committed by
Len Brown
96f73749 eb57c1cf

+7 -17
+2 -12
Documentation/power/userland-swsusp.txt
··· 67 67 SNAPSHOT_FREE_SWAP_PAGES - free all swap pages allocated with 68 68 SNAPSHOT_GET_SWAP_PAGE 69 69 70 - SNAPSHOT_SET_SWAP_FILE - set the resume partition (the last ioctl() argument 71 - should specify the device's major and minor numbers in the old 72 - two-byte format, as returned by the stat() function in the .st_rdev 73 - member of the stat structure) 74 - 75 70 SNAPSHOT_SET_SWAP_AREA - set the resume partition and the offset (in <PAGE_SIZE> 76 71 units) from the beginning of the partition at which the swap header is 77 72 located (the last ioctl() argument should point to a struct 78 73 resume_swap_area, as defined in kernel/power/power.h, containing the 79 - resume device specification, as for the SNAPSHOT_SET_SWAP_FILE ioctl(), 80 - and the offset); for swap partitions the offset is always 0, but it is 81 - different to zero for swap files (please see 74 + resume device specification and the offset); for swap partitions the 75 + offset is always 0, but it is different from zero for swap files (see 82 76 Documentation/swsusp-and-swap-files.txt for details). 83 - The SNAPSHOT_SET_SWAP_AREA ioctl() is considered as a replacement for 84 - SNAPSHOT_SET_SWAP_FILE which is regarded as obsolete. It is 85 - recommended to always use this call, because the code to set the resume 86 - partition may be removed from future kernels 87 77 88 78 SNAPSHOT_PLATFORM_SUPPORT - enable/disable the hibernation platform support, 89 79 depending on the argument value (enable, if the argument is nonzero)
-1
kernel/power/power.h
··· 154 154 #define SNAPSHOT_AVAIL_SWAP _IOR(SNAPSHOT_IOC_MAGIC, 7, void *) 155 155 #define SNAPSHOT_GET_SWAP_PAGE _IOR(SNAPSHOT_IOC_MAGIC, 8, void *) 156 156 #define SNAPSHOT_FREE_SWAP_PAGES _IO(SNAPSHOT_IOC_MAGIC, 9) 157 - #define SNAPSHOT_SET_SWAP_FILE _IOW(SNAPSHOT_IOC_MAGIC, 10, unsigned int) 158 157 #define SNAPSHOT_S2RAM _IO(SNAPSHOT_IOC_MAGIC, 11) 159 158 #define SNAPSHOT_SET_SWAP_AREA _IOW(SNAPSHOT_IOC_MAGIC, 13, \ 160 159 struct resume_swap_area)
+5 -4
kernel/power/user.c
··· 29 29 #include "power.h" 30 30 31 31 /* 32 - * NOTE: The SNAPSHOT_PMOPS ioctl is obsolete and will be removed in the 33 - * future. It is only preserved here for compatibility with existing userland 34 - * utilities. 32 + * NOTE: The SNAPSHOT_SET_SWAP_FILE and SNAPSHOT_PMOPS ioctls are obsolete and 33 + * will be removed in the future. They are only preserved here for 34 + * compatibility with existing userland utilities. 35 35 */ 36 + #define SNAPSHOT_SET_SWAP_FILE _IOW(SNAPSHOT_IOC_MAGIC, 10, unsigned int) 36 37 #define SNAPSHOT_PMOPS _IOW(SNAPSHOT_IOC_MAGIC, 12, unsigned int) 37 38 38 39 #define PMOPS_PREPARE 1 ··· 261 260 free_all_swap_pages(data->swap); 262 261 break; 263 262 264 - case SNAPSHOT_SET_SWAP_FILE: 263 + case SNAPSHOT_SET_SWAP_FILE: /* This ioctl is deprecated */ 265 264 if (!swsusp_swap_in_use()) { 266 265 /* 267 266 * User space encodes device types as two-byte values,