Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/savage: off by one in savage_bci_cmdbuf()

The > should be >= here so that we don't read beyond the end of the
dma->buflist[] array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180704094810.whrgn6jxe7uibnfv@kili.mountain

authored by

Dan Carpenter and committed by
Daniel Vetter
968d72e6 4dd3cdb2

+1 -1
+1 -1
drivers/gpu/drm/savage/savage_state.c
··· 971 971 LOCK_TEST_WITH_RETURN(dev, file_priv); 972 972 973 973 if (dma && dma->buflist) { 974 - if (cmdbuf->dma_idx > dma->buf_count) { 974 + if (cmdbuf->dma_idx >= dma->buf_count) { 975 975 DRM_ERROR 976 976 ("vertex buffer index %u out of range (0-%u)\n", 977 977 cmdbuf->dma_idx, dma->buf_count - 1);