Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

DMA-API: net: sfc/efx.c: replace dma_set_mask()+dma_set_coherent_mask() with new helper

Replace the following sequence:

dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);

with a call to the new helper dma_set_mask_and_coherent().

Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

+1 -11
+1 -11
drivers/net/ethernet/sfc/efx.c
··· 1121 1121 */ 1122 1122 while (dma_mask > 0x7fffffffUL) { 1123 1123 if (dma_supported(&pci_dev->dev, dma_mask)) { 1124 - rc = dma_set_mask(&pci_dev->dev, dma_mask); 1124 + rc = dma_set_mask_and_coherent(&pci_dev->dev, dma_mask); 1125 1125 if (rc == 0) 1126 1126 break; 1127 1127 } ··· 1134 1134 } 1135 1135 netif_dbg(efx, probe, efx->net_dev, 1136 1136 "using DMA mask %llx\n", (unsigned long long) dma_mask); 1137 - rc = dma_set_coherent_mask(&pci_dev->dev, dma_mask); 1138 - if (rc) { 1139 - /* dma_set_coherent_mask() is not *allowed* to 1140 - * fail with a mask that dma_set_mask() accepted, 1141 - * but just in case... 1142 - */ 1143 - netif_err(efx, probe, efx->net_dev, 1144 - "failed to set consistent DMA mask\n"); 1145 - goto fail2; 1146 - } 1147 1137 1148 1138 efx->membase_phys = pci_resource_start(efx->pci_dev, EFX_MEM_BAR); 1149 1139 rc = pci_request_region(pci_dev, EFX_MEM_BAR, "sfc");