Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
tjh.dev
kernel
os
linux
sis190 endianness
Check in sis190_rx_interrupt() is broken on big-endian
(desc->status is little-endian and everything else actually uses
it correctly, including other checks for OWNbit.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
authored by Al Viro and committed by Jeff Garzik 961994a0 87e417b2
+4
-4
drivers/net/sis190.c
+4
-4
drivers/net/sis190.c
···
474
static inline void sis190_make_unusable_by_asic(struct RxDesc *desc)
475
{
476
desc->PSize = 0x0;
477
-
desc->addr = 0xdeadbeef;
478
desc->size &= cpu_to_le32(RingEnd);
479
wmb();
480
desc->status = 0x0;
···
580
struct RxDesc *desc = tp->RxDescRing + entry;
581
u32 status;
582
583
-
if (desc->status & OWNbit)
584
break;
585
586
status = le32_to_cpu(desc->PSize);
···
1538
1539
/* Get MAC address from EEPROM */
1540
for (i = 0; i < MAC_ADDR_LEN / 2; i++) {
1541
-
__le16 w = sis190_read_eeprom(ioaddr, EEPROMMACAddr + i);
1542
1543
-
((u16 *)dev->dev_addr)[i] = le16_to_cpu(w);
1544
}
1545
1546
sis190_set_rgmii(tp, sis190_read_eeprom(ioaddr, EEPROMInfo));
···
474
static inline void sis190_make_unusable_by_asic(struct RxDesc *desc)
475
{
476
desc->PSize = 0x0;
477
+
desc->addr = cpu_to_le32(0xdeadbeef);
478
desc->size &= cpu_to_le32(RingEnd);
479
wmb();
480
desc->status = 0x0;
···
580
struct RxDesc *desc = tp->RxDescRing + entry;
581
u32 status;
582
583
+
if (le32_to_cpu(desc->status) & OWNbit)
584
break;
585
586
status = le32_to_cpu(desc->PSize);
···
1538
1539
/* Get MAC address from EEPROM */
1540
for (i = 0; i < MAC_ADDR_LEN / 2; i++) {
1541
+
u16 w = sis190_read_eeprom(ioaddr, EEPROMMACAddr + i);
1542
1543
+
((__le16 *)dev->dev_addr)[i] = cpu_to_le16(w);
1544
}
1545
1546
sis190_set_rgmii(tp, sis190_read_eeprom(ioaddr, EEPROMInfo));