Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

char: mxser, fix ISA board lookup

There's a bug in the mxser kernel module that still appears in the
2.6.29.4 kernel.

mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the
not of the ioaddr, you're effectively passing 0 which means it won't be
able to talk to an ISA card. I have tested this, and removing the !
fixes the problem.

Cc: "Peter Botha" <peterb@goldcircle.co.za>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Peter Botha and committed by
Linus Torvalds
96050dfb a61d90d7

+1 -1
+1 -1
drivers/char/mxser.c
··· 2711 2711 continue; 2712 2712 2713 2713 brd = &mxser_boards[m]; 2714 - retval = mxser_get_ISA_conf(!ioaddr[b], brd); 2714 + retval = mxser_get_ISA_conf(ioaddr[b], brd); 2715 2715 if (retval <= 0) { 2716 2716 brd->info = NULL; 2717 2717 continue;