Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

UBI: document UBI_IOCVOLUP better in user header

The current ioctl define implies that this func expects to be passed a
64bit number directly rather than a pointer to a 64bit. The code that
processes this ioctl shows that it clearly expects a pointer.

It'd be best if we could change the type to "__s64*", but that would
change the generated ioctl number thus breaking the userland ABI. So
just add a comment for intrepid developers.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

authored by

Mike Frysinger and committed by
Artem Bityutskiy
95f9a4d2 1557b9e1

+4 -1
+4 -1
include/uapi/mtd/ubi-user.h
··· 173 173 174 174 #define UBI_VOL_IOC_MAGIC 'O' 175 175 176 - /* Start UBI volume update */ 176 + /* Start UBI volume update 177 + * Note: This actually takes a pointer (__s64*), but we can't change 178 + * that without breaking the ABI on 32bit systems 179 + */ 177 180 #define UBI_IOCVOLUP _IOW(UBI_VOL_IOC_MAGIC, 0, __s64) 178 181 /* LEB erasure command, used for debugging, disabled by default */ 179 182 #define UBI_IOCEBER _IOW(UBI_VOL_IOC_MAGIC, 1, __s32)