Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/omapdrm: Use regular fbdev I/O helpers

Use the regular fbdev helpers for framebuffer I/O instead of DRM's
helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers
are mere wrappers around the fbdev code.

By using fbdev helpers directly within each DRM fbdev emulation,
we can eventually remove DRM's wrapper functions entirely.

v4:
* use initializer macros for struct fb_ops
v2:
* use FB_SYS_HELPERS option

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Tomi Valkeinen <tomba@kernel.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230530151228.22979-9-tzimmermann@suse.de

+4 -8
+1
drivers/gpu/drm/omapdrm/Kconfig
··· 4 4 depends on DRM && OF 5 5 depends on ARCH_OMAP2PLUS 6 6 select DRM_KMS_HELPER 7 + select FB_SYS_HELPERS if DRM_FBDEV_EMULATION 7 8 select VIDEOMODE_HELPERS 8 9 select HDMI 9 10 default n
+3 -8
drivers/gpu/drm/omapdrm/omap_fbdev.c
··· 4 4 * Author: Rob Clark <rob@ti.com> 5 5 */ 6 6 7 + #include <linux/fb.h> 8 + 7 9 #include <drm/drm_drv.h> 8 10 #include <drm/drm_crtc_helper.h> 9 11 #include <drm/drm_fb_helper.h> ··· 97 95 98 96 static const struct fb_ops omap_fb_ops = { 99 97 .owner = THIS_MODULE, 100 - 98 + FB_DEFAULT_SYS_OPS, 101 99 .fb_check_var = drm_fb_helper_check_var, 102 100 .fb_set_par = drm_fb_helper_set_par, 103 101 .fb_setcmap = drm_fb_helper_setcmap, 104 102 .fb_blank = drm_fb_helper_blank, 105 103 .fb_pan_display = omap_fbdev_pan_display, 106 104 .fb_ioctl = drm_fb_helper_ioctl, 107 - 108 - .fb_read = drm_fb_helper_sys_read, 109 - .fb_write = drm_fb_helper_sys_write, 110 - .fb_fillrect = drm_fb_helper_sys_fillrect, 111 - .fb_copyarea = drm_fb_helper_sys_copyarea, 112 - .fb_imageblit = drm_fb_helper_sys_imageblit, 113 - 114 105 .fb_destroy = omap_fbdev_fb_destroy, 115 106 }; 116 107