Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: spi-bfin5xx: Calculate transfer speed unconditionally

SPI core validates the transfer speed and defaults to spi->max_speed_hz in
case the transfer speed is not set so code here won't use the
chip->baud value (which is derived from spi->max_speed_hz).

Please note driver uses chip->baud at the beginning of message transmission
by calling the bfin_spi_restore_state() but then programs per transfer
speed in bfin_spi_pump_transfers(). I'm not familiar with the HW so I don't
know would it be possible to remove chip->baud completely by either using
constant value in bfin_spi_restore_state() or by removing the baud register
write there.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Jarkko Nikula and committed by
Mark Brown
95a8fde2 6ff33f39

+1 -5
+1 -5
drivers/spi/spi-bfin5xx.c
··· 661 661 message->state = RUNNING_STATE; 662 662 dma_config = 0; 663 663 664 - /* Speed setup (surely valid because already checked) */ 665 - if (transfer->speed_hz) 666 - bfin_write(&drv_data->regs->baud, hz_to_spi_baud(transfer->speed_hz)); 667 - else 668 - bfin_write(&drv_data->regs->baud, chip->baud); 664 + bfin_write(&drv_data->regs->baud, hz_to_spi_baud(transfer->speed_hz)); 669 665 670 666 bfin_write(&drv_data->regs->stat, BIT_STAT_CLR); 671 667 bfin_spi_cs_active(drv_data, chip);