Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: cleanup non-bool "valid" data fields

We have bool so use it consistently in all the drivers.

The following Coccinelle script was used:

@@
identifier T;
type t = { char, int };
@@
struct T {
...
- t valid;
+ bool valid;
...
}

@@
identifier v;
@@
(
- v->valid = 0
+ v->valid = false
|
- v->valid = 1
+ v->valid = true
)

followed by sed to fixup the comments:
sed '/bool valid;/{s/!=0/true/;s/zero/false/}'

Few whitespace changes were fixed manually. All modified drivers were
compile-tested.

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Link: https://lore.kernel.org/r/20210924195202.27917-1-fercerpav@gmail.com
[groeck: Fixed up 'u8 valid' to 'boool valid' in atxp1.c]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Paul Fertser and committed by
Guenter Roeck
952a11ca b87783e8

+152 -152
+3 -3
drivers/hwmon/abituguru3.c
··· 145 145 struct device *hwmon_dev; /* hwmon registered device */ 146 146 struct mutex update_lock; /* protect access to data and uGuru */ 147 147 unsigned short addr; /* uguru base address */ 148 - char valid; /* !=0 if following fields are valid */ 148 + bool valid; /* true if following fields are valid */ 149 149 unsigned long last_updated; /* In jiffies */ 150 150 151 151 /* ··· 1083 1083 mutex_lock(&data->update_lock); 1084 1084 if (!data->valid || time_after(jiffies, data->last_updated + HZ)) { 1085 1085 /* Clear data->valid while updating */ 1086 - data->valid = 0; 1086 + data->valid = false; 1087 1087 /* Read alarms */ 1088 1088 if (abituguru3_read_increment_offset(data, 1089 1089 ABIT_UGURU3_SETTINGS_BANK, ··· 1117 1117 goto LEAVE_UPDATE; 1118 1118 } 1119 1119 data->last_updated = jiffies; 1120 - data->valid = 1; 1120 + data->valid = true; 1121 1121 } 1122 1122 LEAVE_UPDATE: 1123 1123 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/ad7414.c
··· 37 37 struct ad7414_data { 38 38 struct i2c_client *client; 39 39 struct mutex lock; /* atomic read data updates */ 40 - char valid; /* !=0 if following fields are valid */ 40 + bool valid; /* true if following fields are valid */ 41 41 unsigned long next_update; /* In jiffies */ 42 42 s16 temp_input; /* Register values */ 43 43 s8 temps[ARRAY_SIZE(AD7414_REG_LIMIT)]; ··· 95 95 } 96 96 97 97 data->next_update = jiffies + HZ + HZ / 2; 98 - data->valid = 1; 98 + data->valid = true; 99 99 } 100 100 101 101 mutex_unlock(&data->lock);
+3 -3
drivers/hwmon/ad7418.c
··· 46 46 enum chips type; 47 47 struct mutex lock; 48 48 int adc_max; /* number of ADC channels */ 49 - char valid; 49 + bool valid; 50 50 unsigned long last_updated; /* In jiffies */ 51 51 s16 temp[3]; /* Register values */ 52 52 u16 in[4]; ··· 111 111 goto abort; 112 112 113 113 data->last_updated = jiffies; 114 - data->valid = 1; 114 + data->valid = true; 115 115 } 116 116 117 117 mutex_unlock(&data->lock); 118 118 return 0; 119 119 120 120 abort: 121 - data->valid = 0; 121 + data->valid = false; 122 122 mutex_unlock(&data->lock); 123 123 return val; 124 124 }
+2 -2
drivers/hwmon/adm1021.c
··· 72 72 const struct attribute_group *groups[3]; 73 73 74 74 struct mutex update_lock; 75 - char valid; /* !=0 if following fields are valid */ 75 + bool valid; /* true if following fields are valid */ 76 76 char low_power; /* !=0 if device in low power mode */ 77 77 unsigned long last_updated; /* In jiffies */ 78 78 ··· 135 135 ADM1023_REG_REM_OFFSET_PREC); 136 136 } 137 137 data->last_updated = jiffies; 138 - data->valid = 1; 138 + data->valid = true; 139 139 } 140 140 141 141 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/adm1025.c
··· 97 97 struct i2c_client *client; 98 98 const struct attribute_group *groups[3]; 99 99 struct mutex update_lock; 100 - char valid; /* zero until following fields are valid */ 100 + bool valid; /* false until following fields are valid */ 101 101 unsigned long last_updated; /* in jiffies */ 102 102 103 103 u8 in[6]; /* register value */ ··· 148 148 ADM1025_REG_VID4) & 0x01) << 4); 149 149 150 150 data->last_updated = jiffies; 151 - data->valid = 1; 151 + data->valid = true; 152 152 } 153 153 154 154 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/adm1026.c
··· 259 259 const struct attribute_group *groups[3]; 260 260 261 261 struct mutex update_lock; 262 - int valid; /* !=0 if following fields are valid */ 262 + bool valid; /* true if following fields are valid */ 263 263 unsigned long last_reading; /* In jiffies */ 264 264 unsigned long last_config; /* In jiffies */ 265 265 ··· 459 459 data->last_config = jiffies; 460 460 } /* last_config */ 461 461 462 - data->valid = 1; 462 + data->valid = true; 463 463 mutex_unlock(&data->update_lock); 464 464 return data; 465 465 }
+2 -2
drivers/hwmon/adm1029.c
··· 99 99 struct adm1029_data { 100 100 struct i2c_client *client; 101 101 struct mutex update_lock; /* protect register access */ 102 - char valid; /* zero until following fields are valid */ 102 + bool valid; /* false until following fields are valid */ 103 103 unsigned long last_updated; /* in jiffies */ 104 104 105 105 /* registers values, signed for temperature, unsigned for other stuff */ ··· 143 143 } 144 144 145 145 data->last_updated = jiffies; 146 - data->valid = 1; 146 + data->valid = true; 147 147 } 148 148 149 149 mutex_unlock(&data->update_lock);
+3 -3
drivers/hwmon/adm1031.c
··· 65 65 const struct attribute_group *groups[3]; 66 66 struct mutex update_lock; 67 67 int chip_type; 68 - char valid; /* !=0 if following fields are valid */ 68 + bool valid; /* true if following fields are valid */ 69 69 unsigned long last_updated; /* In jiffies */ 70 70 unsigned int update_interval; /* In milliseconds */ 71 71 /* ··· 187 187 ADM1031_REG_PWM) >> (4 * chan)) & 0x0f; 188 188 } 189 189 data->last_updated = jiffies; 190 - data->valid = 1; 190 + data->valid = true; 191 191 } 192 192 193 193 mutex_unlock(&data->update_lock); ··· 650 650 data->fan_min[nr]); 651 651 652 652 /* Invalidate the cache: fan speed is no longer valid */ 653 - data->valid = 0; 653 + data->valid = false; 654 654 mutex_unlock(&data->update_lock); 655 655 return count; 656 656 }
+4 -4
drivers/hwmon/amc6821.c
··· 141 141 struct amc6821_data { 142 142 struct i2c_client *client; 143 143 struct mutex update_lock; 144 - char valid; /* zero until following fields are valid */ 144 + bool valid; /* false until following fields are valid */ 145 145 unsigned long last_updated; /* in jiffies */ 146 146 147 147 /* register values */ ··· 258 258 } 259 259 260 260 data->last_updated = jiffies; 261 - data->valid = 1; 261 + data->valid = true; 262 262 } 263 263 mutex_unlock(&data->update_lock); 264 264 return data; ··· 511 511 } 512 512 513 513 mutex_lock(&data->update_lock); 514 - data->valid = 0; 514 + data->valid = false; 515 515 516 516 switch (ix) { 517 517 case 0: ··· 584 584 } 585 585 586 586 EXIT: 587 - data->valid = 0; 587 + data->valid = false; 588 588 mutex_unlock(&data->update_lock); 589 589 return count; 590 590 }
+1 -1
drivers/hwmon/applesmc.c
··· 391 391 cache->len = info[0]; 392 392 memcpy(cache->type, &info[1], 4); 393 393 cache->flags = info[5]; 394 - cache->valid = 1; 394 + cache->valid = true; 395 395 396 396 out: 397 397 mutex_unlock(&smcreg.mutex);
+2 -2
drivers/hwmon/asb100.c
··· 186 186 /* array of 2 pointers to subclients */ 187 187 struct i2c_client *lm75[2]; 188 188 189 - char valid; /* !=0 if following fields are valid */ 189 + bool valid; /* true if following fields are valid */ 190 190 u8 in[7]; /* Register value */ 191 191 u8 in_max[7]; /* Register value */ 192 192 u8 in_min[7]; /* Register value */ ··· 993 993 (asb100_read_value(client, ASB100_REG_ALARM2) << 8); 994 994 995 995 data->last_updated = jiffies; 996 - data->valid = 1; 996 + data->valid = true; 997 997 998 998 dev_dbg(&client->dev, "... device update complete\n"); 999 999 }
+2 -2
drivers/hwmon/asc7621.c
··· 77 77 struct i2c_client client; 78 78 struct device *class_dev; 79 79 struct mutex update_lock; 80 - int valid; /* !=0 if following fields are valid */ 80 + bool valid; /* true if following fields are valid */ 81 81 unsigned long last_high_reading; /* In jiffies */ 82 82 unsigned long last_low_reading; /* In jiffies */ 83 83 /* ··· 1032 1032 data->last_low_reading = jiffies; 1033 1033 } /* last_reading */ 1034 1034 1035 - data->valid = 1; 1035 + data->valid = true; 1036 1036 1037 1037 mutex_unlock(&data->update_lock); 1038 1038
+5 -5
drivers/hwmon/atxp1.c
··· 37 37 struct i2c_client *client; 38 38 struct mutex update_lock; 39 39 unsigned long last_updated; 40 - u8 valid; 40 + bool valid; 41 41 struct { 42 42 u8 vid; /* VID output register */ 43 43 u8 cpu_vid; /* VID input from CPU */ ··· 63 63 data->reg.gpio1 = i2c_smbus_read_byte_data(client, ATXP1_GPIO1); 64 64 data->reg.gpio2 = i2c_smbus_read_byte_data(client, ATXP1_GPIO2); 65 65 66 - data->valid = 1; 66 + data->valid = true; 67 67 } 68 68 69 69 mutex_unlock(&data->update_lock); ··· 136 136 ATXP1_VID, cvid | ATXP1_VIDENA); 137 137 } 138 138 139 - data->valid = 0; 139 + data->valid = false; 140 140 141 141 return count; 142 142 } ··· 180 180 181 181 i2c_smbus_write_byte_data(client, ATXP1_GPIO1, value); 182 182 183 - data->valid = 0; 183 + data->valid = false; 184 184 } 185 185 186 186 return count; ··· 224 224 225 225 i2c_smbus_write_byte_data(client, ATXP1_GPIO2, value); 226 226 227 - data->valid = 0; 227 + data->valid = false; 228 228 } 229 229 230 230 return count;
+1 -1
drivers/hwmon/coretemp.c
··· 167 167 * really help at all. 168 168 */ 169 169 tdata->temp = tdata->tjmax - ((eax >> 16) & 0x7f) * 1000; 170 - tdata->valid = 1; 170 + tdata->valid = true; 171 171 tdata->last_updated = jiffies; 172 172 } 173 173
+2 -2
drivers/hwmon/dme1737.c
··· 203 203 unsigned int addr; /* for ISA devices only */ 204 204 205 205 struct mutex update_lock; 206 - int valid; /* !=0 if following fields are valid */ 206 + bool valid; /* true if following fields are valid */ 207 207 unsigned long last_update; /* in jiffies */ 208 208 unsigned long last_vbat; /* in jiffies */ 209 209 enum chips type; ··· 778 778 } 779 779 780 780 data->last_update = jiffies; 781 - data->valid = 1; 781 + data->valid = true; 782 782 } 783 783 784 784 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/ds1621.c
··· 109 109 struct ds1621_data { 110 110 struct i2c_client *client; 111 111 struct mutex update_lock; 112 - char valid; /* !=0 if following fields are valid */ 112 + bool valid; /* true if following fields are valid */ 113 113 unsigned long last_updated; /* In jiffies */ 114 114 enum chips kind; /* device type */ 115 115 ··· 213 213 new_conf); 214 214 215 215 data->last_updated = jiffies; 216 - data->valid = 1; 216 + data->valid = true; 217 217 } 218 218 219 219 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/ds620.c
··· 56 56 struct ds620_data { 57 57 struct i2c_client *client; 58 58 struct mutex update_lock; 59 - char valid; /* !=0 if following fields are valid */ 59 + bool valid; /* true if following fields are valid */ 60 60 unsigned long last_updated; /* In jiffies */ 61 61 62 62 s16 temp[3]; /* Register values, word */ ··· 118 118 } 119 119 120 120 data->last_updated = jiffies; 121 - data->valid = 1; 121 + data->valid = true; 122 122 } 123 123 abort: 124 124 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/emc6w201.c
··· 45 45 struct emc6w201_data { 46 46 struct i2c_client *client; 47 47 struct mutex update_lock; 48 - char valid; /* zero until following fields are valid */ 48 + bool valid; /* false until following fields are valid */ 49 49 unsigned long last_updated; /* in jiffies */ 50 50 51 51 /* registers values */ ··· 162 162 } 163 163 164 164 data->last_updated = jiffies; 165 - data->valid = 1; 165 + data->valid = true; 166 166 } 167 167 168 168 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/f71805f.c
··· 165 165 struct device *hwmon_dev; 166 166 167 167 struct mutex update_lock; 168 - char valid; /* !=0 if following fields are valid */ 168 + bool valid; /* true if following fields are valid */ 169 169 unsigned long last_updated; /* In jiffies */ 170 170 unsigned long last_limits; /* In jiffies */ 171 171 ··· 404 404 + (f71805f_read8(data, F71805F_REG_STATUS(2)) << 16); 405 405 406 406 data->last_updated = jiffies; 407 - data->valid = 1; 407 + data->valid = true; 408 408 } 409 409 410 410 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/f71882fg.c
··· 253 253 254 254 struct mutex update_lock; 255 255 int temp_start; /* temp numbering start (0 or 1) */ 256 - char valid; /* !=0 if following fields are valid */ 256 + bool valid; /* true if following fields are valid */ 257 257 char auto_point_temp_signed; 258 258 unsigned long last_updated; /* In jiffies */ 259 259 unsigned long last_limits; /* In jiffies */ ··· 1359 1359 F71882FG_REG_IN(nr)); 1360 1360 1361 1361 data->last_updated = jiffies; 1362 - data->valid = 1; 1362 + data->valid = true; 1363 1363 } 1364 1364 1365 1365 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/f75375s.c
··· 85 85 const char *name; 86 86 int kind; 87 87 struct mutex update_lock; /* protect register access */ 88 - char valid; 88 + bool valid; 89 89 unsigned long last_updated; /* In jiffies */ 90 90 unsigned long last_limits; /* In jiffies */ 91 91 ··· 228 228 f75375_read8(client, F75375_REG_VOLT(nr)); 229 229 230 230 data->last_updated = jiffies; 231 - data->valid = 1; 231 + data->valid = true; 232 232 } 233 233 234 234 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/fschmd.c
··· 264 264 unsigned long watchdog_is_open; 265 265 char watchdog_expect_close; 266 266 char watchdog_name[10]; /* must be unique to avoid sysfs conflict */ 267 - char valid; /* zero until following fields are valid */ 267 + bool valid; /* false until following fields are valid */ 268 268 unsigned long last_updated; /* in jiffies */ 269 269 270 270 /* register values */ ··· 1356 1356 FSCHMD_REG_VOLT[data->kind][i]); 1357 1357 1358 1358 data->last_updated = jiffies; 1359 - data->valid = 1; 1359 + data->valid = true; 1360 1360 } 1361 1361 1362 1362 mutex_unlock(&data->update_lock);
+1 -1
drivers/hwmon/g760a.c
··· 95 95 data->fan_sta = g760a_read_value(client, G760A_REG_FAN_STA); 96 96 97 97 data->last_updated = jiffies; 98 - data->valid = 1; 98 + data->valid = true; 99 99 } 100 100 101 101 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/gl518sm.c
··· 107 107 enum chips type; 108 108 109 109 struct mutex update_lock; 110 - char valid; /* !=0 if following fields are valid */ 110 + bool valid; /* true if following fields are valid */ 111 111 unsigned long last_updated; /* In jiffies */ 112 112 113 113 u8 voltage_in[4]; /* Register values; [0] = VDD */ ··· 211 211 gl518_read_value(client, GL518_REG_VIN3); 212 212 213 213 data->last_updated = jiffies; 214 - data->valid = 1; 214 + data->valid = true; 215 215 } 216 216 217 217 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/gl520sm.c
··· 64 64 struct i2c_client *client; 65 65 const struct attribute_group *groups[3]; 66 66 struct mutex update_lock; 67 - char valid; /* zero until the following fields are valid */ 67 + bool valid; /* false until the following fields are valid */ 68 68 unsigned long last_updated; /* in jiffies */ 69 69 70 70 u8 vid; ··· 174 174 } 175 175 176 176 data->last_updated = jiffies; 177 - data->valid = 1; 177 + data->valid = true; 178 178 } 179 179 180 180 mutex_unlock(&data->update_lock);
+1 -1
drivers/hwmon/ibmaem.c
··· 127 127 struct device *hwmon_dev; 128 128 struct platform_device *pdev; 129 129 struct mutex lock; 130 - char valid; 130 + bool valid; 131 131 unsigned long last_updated; /* In jiffies */ 132 132 u8 ver_major; 133 133 u8 ver_minor;
+2 -2
drivers/hwmon/ibmpex.c
··· 66 66 struct device *hwmon_dev; 67 67 struct device *bmc_device; 68 68 struct mutex lock; 69 - char valid; 69 + bool valid; 70 70 unsigned long last_updated; /* In jiffies */ 71 71 72 72 struct ipmi_addr address; ··· 239 239 } 240 240 241 241 data->last_updated = jiffies; 242 - data->valid = 1; 242 + data->valid = true; 243 243 244 244 out: 245 245 mutex_unlock(&data->lock);
+6 -6
drivers/hwmon/it87.c
··· 519 519 unsigned short addr; 520 520 const char *name; 521 521 struct mutex update_lock; 522 - char valid; /* !=0 if following fields are valid */ 522 + bool valid; /* true if following fields are valid */ 523 523 unsigned long last_updated; /* In jiffies */ 524 524 525 525 u16 in_scaled; /* Internal voltage sensors are scaled */ ··· 844 844 data->vid &= 0x3f; 845 845 } 846 846 data->last_updated = jiffies; 847 - data->valid = 1; 847 + data->valid = true; 848 848 } 849 849 850 850 mutex_unlock(&data->update_lock); ··· 980 980 regval |= 0x80; 981 981 it87_write_value(data, IT87_REG_BEEP_ENABLE, regval); 982 982 } 983 - data->valid = 0; 983 + data->valid = false; 984 984 reg = IT87_REG_TEMP_OFFSET[nr]; 985 985 break; 986 986 } ··· 1079 1079 it87_write_value(data, IT87_REG_TEMP_ENABLE, data->sensor); 1080 1080 if (has_temp_old_peci(data, nr)) 1081 1081 it87_write_value(data, IT87_REG_TEMP_EXTRA, data->extra); 1082 - data->valid = 0; /* Force cache refresh */ 1082 + data->valid = false; /* Force cache refresh */ 1083 1083 mutex_unlock(&data->update_lock); 1084 1084 return count; 1085 1085 } ··· 1834 1834 config |= BIT(5); 1835 1835 it87_write_value(data, IT87_REG_CONFIG, config); 1836 1836 /* Invalidate cache to force re-read */ 1837 - data->valid = 0; 1837 + data->valid = false; 1838 1838 } 1839 1839 mutex_unlock(&data->update_lock); 1840 1840 ··· 3229 3229 it87_start_monitoring(data); 3230 3230 3231 3231 /* force update */ 3232 - data->valid = 0; 3232 + data->valid = false; 3233 3233 3234 3234 mutex_unlock(&data->update_lock); 3235 3235
+1 -1
drivers/hwmon/lineage-pem.c
··· 191 191 i2c_smbus_write_byte(client, PEM_CLEAR_INFO_FLAGS); 192 192 193 193 data->last_updated = jiffies; 194 - data->valid = 1; 194 + data->valid = true; 195 195 } 196 196 abort: 197 197 mutex_unlock(&data->update_lock);
+3 -3
drivers/hwmon/lm63.c
··· 139 139 struct i2c_client *client; 140 140 struct mutex update_lock; 141 141 const struct attribute_group *groups[5]; 142 - char valid; /* zero until following fields are valid */ 142 + bool valid; /* false until following fields are valid */ 143 143 char lut_valid; /* zero until lut fields are valid */ 144 144 unsigned long last_updated; /* in jiffies */ 145 145 unsigned long lut_last_updated; /* in jiffies */ ··· 289 289 LM63_REG_ALERT_STATUS) & 0x7F; 290 290 291 291 data->last_updated = jiffies; 292 - data->valid = 1; 292 + data->valid = true; 293 293 } 294 294 295 295 lm63_update_lut(data); ··· 714 714 reg = i2c_smbus_read_byte_data(client, LM96163_REG_TRUTHERM) & ~0x02; 715 715 i2c_smbus_write_byte_data(client, LM96163_REG_TRUTHERM, 716 716 reg | (data->trutherm ? 0x02 : 0x00)); 717 - data->valid = 0; 717 + data->valid = false; 718 718 mutex_unlock(&data->update_lock); 719 719 720 720 return count;
+2 -2
drivers/hwmon/lm77.c
··· 55 55 struct lm77_data { 56 56 struct i2c_client *client; 57 57 struct mutex update_lock; 58 - char valid; 58 + bool valid; 59 59 unsigned long last_updated; /* In jiffies */ 60 60 int temp[t_num_temp]; /* index using temp_index */ 61 61 u8 alarms; ··· 118 118 data->alarms = 119 119 lm77_read_value(client, LM77_REG_TEMP) & 0x0007; 120 120 data->last_updated = jiffies; 121 - data->valid = 1; 121 + data->valid = true; 122 122 } 123 123 124 124 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/lm78.c
··· 117 117 int isa_addr; 118 118 119 119 struct mutex update_lock; 120 - char valid; /* !=0 if following fields are valid */ 120 + bool valid; /* true if following fields are valid */ 121 121 unsigned long last_updated; /* In jiffies */ 122 122 123 123 u8 in[7]; /* Register value */ ··· 772 772 data->alarms = lm78_read_value(data, LM78_REG_ALARM1) + 773 773 (lm78_read_value(data, LM78_REG_ALARM2) << 8); 774 774 data->last_updated = jiffies; 775 - data->valid = 1; 775 + data->valid = true; 776 776 777 777 data->fan_div[2] = 1; 778 778 }
+3 -3
drivers/hwmon/lm80.c
··· 117 117 struct i2c_client *client; 118 118 struct mutex update_lock; 119 119 char error; /* !=0 if error occurred during last update */ 120 - char valid; /* !=0 if following fields are valid */ 120 + bool valid; /* true if following fields are valid */ 121 121 unsigned long last_updated; /* In jiffies */ 122 122 123 123 u8 in[i_num_in][7]; /* Register value, 1st index is enum in_index */ ··· 236 236 data->alarms = prev_rv + (rv << 8); 237 237 238 238 data->last_updated = jiffies; 239 - data->valid = 1; 239 + data->valid = true; 240 240 data->error = 0; 241 241 } 242 242 goto done; 243 243 244 244 abort: 245 245 ret = ERR_PTR(rv); 246 - data->valid = 0; 246 + data->valid = false; 247 247 data->error = 1; 248 248 249 249 done:
+2 -2
drivers/hwmon/lm83.c
··· 105 105 struct i2c_client *client; 106 106 const struct attribute_group *groups[3]; 107 107 struct mutex update_lock; 108 - char valid; /* zero until following fields are valid */ 108 + bool valid; /* false until following fields are valid */ 109 109 unsigned long last_updated; /* in jiffies */ 110 110 111 111 /* registers values */ ··· 137 137 << 8); 138 138 139 139 data->last_updated = jiffies; 140 - data->valid = 1; 140 + data->valid = true; 141 141 } 142 142 143 143 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/lm85.c
··· 294 294 bool has_vid5; /* true if VID5 is configured for ADT7463 or ADT7468 */ 295 295 296 296 struct mutex update_lock; 297 - int valid; /* !=0 if following fields are valid */ 297 + bool valid; /* true if following fields are valid */ 298 298 unsigned long last_reading; /* In jiffies */ 299 299 unsigned long last_config; /* In jiffies */ 300 300 ··· 541 541 data->last_config = jiffies; 542 542 } /* last_config */ 543 543 544 - data->valid = 1; 544 + data->valid = true; 545 545 546 546 mutex_unlock(&data->update_lock); 547 547
+2 -2
drivers/hwmon/lm87.c
··· 141 141 142 142 struct lm87_data { 143 143 struct mutex update_lock; 144 - char valid; /* zero until following fields are valid */ 144 + bool valid; /* false until following fields are valid */ 145 145 unsigned long last_updated; /* In jiffies */ 146 146 147 147 u8 channel; /* register value */ ··· 251 251 data->aout = lm87_read_value(client, LM87_REG_AOUT); 252 252 253 253 data->last_updated = jiffies; 254 - data->valid = 1; 254 + data->valid = true; 255 255 } 256 256 257 257 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/lm92.c
··· 99 99 struct lm92_data { 100 100 struct i2c_client *client; 101 101 struct mutex update_lock; 102 - char valid; /* zero until following fields are valid */ 102 + bool valid; /* false until following fields are valid */ 103 103 unsigned long last_updated; /* in jiffies */ 104 104 105 105 /* registers values */ ··· 126 126 i2c_smbus_read_word_swapped(client, regs[i]); 127 127 } 128 128 data->last_updated = jiffies; 129 - data->valid = 1; 129 + data->valid = true; 130 130 } 131 131 132 132 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/lm93.c
··· 202 202 /* client update function */ 203 203 void (*update)(struct lm93_data *, struct i2c_client *); 204 204 205 - char valid; /* !=0 if following fields are valid */ 205 + bool valid; /* true if following fields are valid */ 206 206 207 207 /* register values, arranged by block read groups */ 208 208 struct block1_t block1; ··· 917 917 918 918 data->update(data, client); 919 919 data->last_updated = jiffies; 920 - data->valid = 1; 920 + data->valid = true; 921 921 } 922 922 923 923 mutex_unlock(&data->update_lock);
+4 -4
drivers/hwmon/lm95241.c
··· 78 78 struct mutex update_lock; 79 79 unsigned long last_updated; /* in jiffies */ 80 80 unsigned long interval; /* in milli-seconds */ 81 - char valid; /* zero until following fields are valid */ 81 + bool valid; /* false until following fields are valid */ 82 82 /* registers values */ 83 83 u8 temp[ARRAY_SIZE(lm95241_reg_address)]; 84 84 u8 status, config, model, trutherm; ··· 118 118 data->status = i2c_smbus_read_byte_data(client, 119 119 LM95241_REG_R_STATUS); 120 120 data->last_updated = jiffies; 121 - data->valid = 1; 121 + data->valid = true; 122 122 } 123 123 124 124 mutex_unlock(&data->update_lock); ··· 257 257 else 258 258 data->config &= ~R2DF_MASK; 259 259 } 260 - data->valid = 0; 260 + data->valid = false; 261 261 ret = i2c_smbus_write_byte_data(client, LM95241_REG_RW_CONFIG, 262 262 data->config); 263 263 break; ··· 273 273 else 274 274 data->config &= ~R2DF_MASK; 275 275 } 276 - data->valid = 0; 276 + data->valid = false; 277 277 ret = i2c_smbus_write_byte_data(client, LM95241_REG_RW_CONFIG, 278 278 data->config); 279 279 break;
+1 -1
drivers/hwmon/ltc4151.c
··· 77 77 data->regs[i] = val; 78 78 } 79 79 data->last_updated = jiffies; 80 - data->valid = 1; 80 + data->valid = true; 81 81 } 82 82 abort: 83 83 mutex_unlock(&data->update_lock);
+1 -1
drivers/hwmon/ltc4215.c
··· 64 64 } 65 65 66 66 data->last_updated = jiffies; 67 - data->valid = 1; 67 + data->valid = true; 68 68 } 69 69 70 70 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/ltc4261.c
··· 73 73 "Failed to read ADC value: error %d\n", 74 74 val); 75 75 ret = ERR_PTR(val); 76 - data->valid = 0; 76 + data->valid = false; 77 77 goto abort; 78 78 } 79 79 data->regs[i] = val; 80 80 } 81 81 data->last_updated = jiffies; 82 - data->valid = 1; 82 + data->valid = true; 83 83 } 84 84 abort: 85 85 mutex_unlock(&data->update_lock);
+1 -1
drivers/hwmon/max16065.c
··· 166 166 = i2c_smbus_read_byte_data(client, MAX16065_FAULT(i)); 167 167 168 168 data->last_updated = jiffies; 169 - data->valid = 1; 169 + data->valid = true; 170 170 } 171 171 mutex_unlock(&data->update_lock); 172 172 return data;
+2 -2
drivers/hwmon/max1619.c
··· 79 79 struct max1619_data { 80 80 struct i2c_client *client; 81 81 struct mutex update_lock; 82 - char valid; /* zero until following fields are valid */ 82 + bool valid; /* false until following fields are valid */ 83 83 unsigned long last_updated; /* in jiffies */ 84 84 85 85 /* registers values */ ··· 124 124 data->alarms ^= 0x02; 125 125 126 126 data->last_updated = jiffies; 127 - data->valid = 1; 127 + data->valid = true; 128 128 } 129 129 130 130 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/max1668.c
··· 58 58 enum chips type; 59 59 60 60 struct mutex update_lock; 61 - char valid; /* !=0 if following fields are valid */ 61 + bool valid; /* true if following fields are valid */ 62 62 unsigned long last_updated; /* In jiffies */ 63 63 64 64 /* 1x local and 4x remote */ ··· 120 120 data->alarms |= val; 121 121 122 122 data->last_updated = jiffies; 123 - data->valid = 1; 123 + data->valid = true; 124 124 abort: 125 125 mutex_unlock(&data->update_lock); 126 126
+2 -2
drivers/hwmon/max6639.c
··· 69 69 struct max6639_data { 70 70 struct i2c_client *client; 71 71 struct mutex update_lock; 72 - char valid; /* !=0 if following fields are valid */ 72 + bool valid; /* true if following fields are valid */ 73 73 unsigned long last_updated; /* In jiffies */ 74 74 75 75 /* Register values sampled regularly */ ··· 141 141 } 142 142 143 143 data->last_updated = jiffies; 144 - data->valid = 1; 144 + data->valid = true; 145 145 } 146 146 abort: 147 147 mutex_unlock(&data->update_lock);
+1 -1
drivers/hwmon/max6642.c
··· 181 181 MAX6642_REG_R_STATUS); 182 182 183 183 data->last_updated = jiffies; 184 - data->valid = 1; 184 + data->valid = true; 185 185 } 186 186 187 187 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/pc87360.c
··· 178 178 struct device *hwmon_dev; 179 179 struct mutex lock; 180 180 struct mutex update_lock; 181 - char valid; /* !=0 if following fields are valid */ 181 + bool valid; /* true if following fields are valid */ 182 182 unsigned long last_updated; /* In jiffies */ 183 183 184 184 int address[3]; ··· 1673 1673 } 1674 1674 1675 1675 data->last_updated = jiffies; 1676 - data->valid = 1; 1676 + data->valid = true; 1677 1677 } 1678 1678 1679 1679 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/sch5636.c
··· 56 56 struct device *hwmon_dev; 57 57 58 58 struct mutex update_lock; 59 - char valid; /* !=0 if following fields are valid */ 59 + bool valid; /* true if following fields are valid */ 60 60 unsigned long last_updated; /* In jiffies */ 61 61 u8 in[SCH5636_NO_INS]; 62 62 u8 temp_val[SCH5636_NO_TEMPS]; ··· 140 140 } 141 141 142 142 data->last_updated = jiffies; 143 - data->valid = 1; 143 + data->valid = true; 144 144 abort: 145 145 mutex_unlock(&data->update_lock); 146 146 return ret;
+2 -2
drivers/hwmon/sht21.c
··· 41 41 unsigned long last_update; 42 42 int temperature; 43 43 int humidity; 44 - char valid; 44 + bool valid; 45 45 char eic[18]; 46 46 }; 47 47 ··· 105 105 goto out; 106 106 sht21->humidity = sht21_rh_ticks_to_per_cent_mille(ret); 107 107 sht21->last_update = jiffies; 108 - sht21->valid = 1; 108 + sht21->valid = true; 109 109 } 110 110 out: 111 111 mutex_unlock(&sht21->lock);
+2 -2
drivers/hwmon/sis5595.c
··· 172 172 struct mutex lock; 173 173 174 174 struct mutex update_lock; 175 - char valid; /* !=0 if following fields are valid */ 175 + bool valid; /* true if following fields are valid */ 176 176 unsigned long last_updated; /* In jiffies */ 177 177 char maxins; /* == 3 if temp enabled, otherwise == 4 */ 178 178 u8 revision; /* Reg. value */ ··· 728 728 sis5595_read_value(data, SIS5595_REG_ALARM1) | 729 729 (sis5595_read_value(data, SIS5595_REG_ALARM2) << 8); 730 730 data->last_updated = jiffies; 731 - data->valid = 1; 731 + data->valid = true; 732 732 } 733 733 734 734 mutex_unlock(&data->update_lock);
+1 -1
drivers/hwmon/smm665.c
··· 265 265 data->adc[i] = val; 266 266 } 267 267 data->last_updated = jiffies; 268 - data->valid = 1; 268 + data->valid = true; 269 269 } 270 270 abort: 271 271 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/smsc47b397.c
··· 96 96 97 97 struct mutex update_lock; 98 98 unsigned long last_updated; /* in jiffies */ 99 - int valid; 99 + bool valid; 100 100 101 101 /* register values */ 102 102 u16 fan[4]; ··· 137 137 } 138 138 139 139 data->last_updated = jiffies; 140 - data->valid = 1; 140 + data->valid = true; 141 141 142 142 dev_dbg(dev, "... device update complete\n"); 143 143 }
+2 -2
drivers/hwmon/smsc47m192.c
··· 86 86 struct i2c_client *client; 87 87 const struct attribute_group *groups[3]; 88 88 struct mutex update_lock; 89 - char valid; /* !=0 if following fields are valid */ 89 + bool valid; /* true if following fields are valid */ 90 90 unsigned long last_updated; /* In jiffies */ 91 91 92 92 u8 in[8]; /* Register value */ ··· 157 157 SMSC47M192_REG_ALARM2) << 8); 158 158 159 159 data->last_updated = jiffies; 160 - data->valid = 1; 160 + data->valid = true; 161 161 } 162 162 163 163 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/thmc50.c
··· 62 62 enum chips type; 63 63 unsigned long last_updated; /* In jiffies */ 64 64 char has_temp3; /* !=0 if it is ADM1022 in temp3 mode */ 65 - char valid; /* !=0 if following fields are valid */ 65 + bool valid; /* true if following fields are valid */ 66 66 67 67 /* Register values */ 68 68 s8 temp_input[3]; ··· 107 107 data->alarms = 108 108 i2c_smbus_read_byte_data(client, THMC50_REG_INTR); 109 109 data->last_updated = jiffies; 110 - data->valid = 1; 110 + data->valid = true; 111 111 } 112 112 113 113 mutex_unlock(&data->update_lock);
+3 -3
drivers/hwmon/tmp401.c
··· 136 136 struct i2c_client *client; 137 137 const struct attribute_group *groups[3]; 138 138 struct mutex update_lock; 139 - char valid; /* zero until following fields are valid */ 139 + bool valid; /* false until following fields are valid */ 140 140 unsigned long last_updated; /* in jiffies */ 141 141 enum chips kind; 142 142 ··· 267 267 data->temp_crit_hyst = val; 268 268 269 269 data->last_updated = jiffies; 270 - data->valid = 1; 270 + data->valid = true; 271 271 } 272 272 273 273 abort: ··· 413 413 } 414 414 mutex_lock(&data->update_lock); 415 415 i2c_smbus_write_byte_data(client, TMP401_TEMP_MSB_WRITE[5][0], val); 416 - data->valid = 0; 416 + data->valid = false; 417 417 mutex_unlock(&data->update_lock); 418 418 419 419 return count;
+3 -3
drivers/hwmon/tmp421.c
··· 94 94 struct hwmon_channel_info temp_info; 95 95 const struct hwmon_channel_info *info[2]; 96 96 struct hwmon_chip_info chip; 97 - char valid; 97 + bool valid; 98 98 unsigned long last_updated; 99 99 unsigned long channels; 100 100 u8 config; ··· 141 141 data->temp[i] |= ret; 142 142 } 143 143 data->last_updated = jiffies; 144 - data->valid = 1; 144 + data->valid = true; 145 145 } 146 146 147 147 exit: 148 148 mutex_unlock(&data->update_lock); 149 149 150 150 if (ret < 0) { 151 - data->valid = 0; 151 + data->valid = false; 152 152 return ret; 153 153 } 154 154
+2 -2
drivers/hwmon/via686a.c
··· 304 304 const char *name; 305 305 struct device *hwmon_dev; 306 306 struct mutex update_lock; 307 - char valid; /* !=0 if following fields are valid */ 307 + bool valid; /* true if following fields are valid */ 308 308 unsigned long last_updated; /* In jiffies */ 309 309 310 310 u8 in[5]; /* Register value */ ··· 800 800 VIA686A_REG_ALARM1) | 801 801 (via686a_read_value(data, VIA686A_REG_ALARM2) << 8); 802 802 data->last_updated = jiffies; 803 - data->valid = 1; 803 + data->valid = true; 804 804 } 805 805 806 806 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/vt1211.c
··· 105 105 struct device *hwmon_dev; 106 106 107 107 struct mutex update_lock; 108 - char valid; /* !=0 if following fields are valid */ 108 + bool valid; /* true if following fields are valid */ 109 109 unsigned long last_updated; /* In jiffies */ 110 110 111 111 /* Register values */ ··· 319 319 vt1211_read8(data, VT1211_REG_ALARM1); 320 320 321 321 data->last_updated = jiffies; 322 - data->valid = 1; 322 + data->valid = true; 323 323 } 324 324 325 325 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/vt8231.c
··· 145 145 146 146 struct mutex update_lock; 147 147 struct device *hwmon_dev; 148 - char valid; /* !=0 if following fields are valid */ 148 + bool valid; /* true if following fields are valid */ 149 149 unsigned long last_updated; /* In jiffies */ 150 150 151 151 u8 in[6]; /* Register value */ ··· 929 929 data->alarms &= ~0x80; 930 930 931 931 data->last_updated = jiffies; 932 - data->valid = 1; 932 + data->valid = true; 933 933 } 934 934 935 935 mutex_unlock(&data->update_lock);
+4 -4
drivers/hwmon/w83627ehf.c
··· 320 320 const u16 *scale_in; 321 321 322 322 struct mutex update_lock; 323 - char valid; /* !=0 if following fields are valid */ 323 + bool valid; /* true if following fields are valid */ 324 324 unsigned long last_updated; /* In jiffies */ 325 325 326 326 /* Register values */ ··· 688 688 W83627EHF_REG_CASEOPEN_DET); 689 689 690 690 data->last_updated = jiffies; 691 - data->valid = 1; 691 + data->valid = true; 692 692 } 693 693 694 694 mutex_unlock(&data->update_lock); ··· 1099 1099 reg = w83627ehf_read_value(data, W83627EHF_REG_CASEOPEN_CLR); 1100 1100 w83627ehf_write_value(data, W83627EHF_REG_CASEOPEN_CLR, reg | mask); 1101 1101 w83627ehf_write_value(data, W83627EHF_REG_CASEOPEN_CLR, reg & ~mask); 1102 - data->valid = 0; /* Force cache refresh */ 1102 + data->valid = false; /* Force cache refresh */ 1103 1103 mutex_unlock(&data->update_lock); 1104 1104 1105 1105 return 0; ··· 2004 2004 w83627ehf_write_value(data, W83627EHF_REG_VBAT, data->vbat); 2005 2005 2006 2006 /* Force re-reading all values */ 2007 - data->valid = 0; 2007 + data->valid = false; 2008 2008 mutex_unlock(&data->update_lock); 2009 2009 2010 2010 return 0;
+3 -3
drivers/hwmon/w83627hf.c
··· 355 355 enum chips type; 356 356 357 357 struct mutex update_lock; 358 - char valid; /* !=0 if following fields are valid */ 358 + bool valid; /* true if following fields are valid */ 359 359 unsigned long last_updated; /* In jiffies */ 360 360 361 361 u8 in[9]; /* Register value */ ··· 448 448 w83627hf_write_value(data, W83781D_REG_SCFG2, data->scfg2); 449 449 450 450 /* Force re-reading all values */ 451 - data->valid = 0; 451 + data->valid = false; 452 452 mutex_unlock(&data->update_lock); 453 453 454 454 return 0; ··· 1905 1905 w83627hf_read_value(data, W83781D_REG_BEEP_INTS1) | 1906 1906 w83627hf_read_value(data, W83781D_REG_BEEP_INTS3) << 16; 1907 1907 data->last_updated = jiffies; 1908 - data->valid = 1; 1908 + data->valid = true; 1909 1909 } 1910 1910 1911 1911 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/w83781d.c
··· 203 203 int isa_addr; 204 204 205 205 struct mutex update_lock; 206 - char valid; /* !=0 if following fields are valid */ 206 + bool valid; /* true if following fields are valid */ 207 207 unsigned long last_updated; /* In jiffies */ 208 208 209 209 struct i2c_client *lm75[2]; /* for secondary I2C addresses */ ··· 1554 1554 W83781D_REG_BEEP_INTS3) << 16; 1555 1555 } 1556 1556 data->last_updated = jiffies; 1557 - data->valid = 1; 1557 + data->valid = true; 1558 1558 } 1559 1559 1560 1560 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/w83791d.c
··· 270 270 struct device *hwmon_dev; 271 271 struct mutex update_lock; 272 272 273 - char valid; /* !=0 if following fields are valid */ 273 + bool valid; /* true if following fields are valid */ 274 274 unsigned long last_updated; /* In jiffies */ 275 275 276 276 /* volts */ ··· 1596 1596 << 4; 1597 1597 1598 1598 data->last_updated = jiffies; 1599 - data->valid = 1; 1599 + data->valid = true; 1600 1600 } 1601 1601 1602 1602 mutex_unlock(&data->update_lock);
+3 -3
drivers/hwmon/w83792d.c
··· 261 261 struct device *hwmon_dev; 262 262 263 263 struct mutex update_lock; 264 - char valid; /* !=0 if following fields are valid */ 264 + bool valid; /* true if following fields are valid */ 265 265 unsigned long last_updated; /* In jiffies */ 266 266 267 267 u8 in[9]; /* Register value */ ··· 740 740 mutex_lock(&data->update_lock); 741 741 reg = w83792d_read_value(client, W83792D_REG_CHASSIS_CLR); 742 742 w83792d_write_value(client, W83792D_REG_CHASSIS_CLR, reg | 0x80); 743 - data->valid = 0; /* Force cache refresh */ 743 + data->valid = false; /* Force cache refresh */ 744 744 mutex_unlock(&data->update_lock); 745 745 746 746 return count; ··· 1589 1589 } 1590 1590 1591 1591 data->last_updated = jiffies; 1592 - data->valid = 1; 1592 + data->valid = true; 1593 1593 } 1594 1594 1595 1595 mutex_unlock(&data->update_lock);
+3 -3
drivers/hwmon/w83793.c
··· 204 204 struct w83793_data { 205 205 struct device *hwmon_dev; 206 206 struct mutex update_lock; 207 - char valid; /* !=0 if following fields are valid */ 207 + bool valid; /* true if following fields are valid */ 208 208 unsigned long last_updated; /* In jiffies */ 209 209 unsigned long last_nonvolatile; /* In jiffies, last time we update the 210 210 * nonvolatile registers ··· 452 452 mutex_lock(&data->update_lock); 453 453 reg = w83793_read_value(client, W83793_REG_CLR_CHASSIS); 454 454 w83793_write_value(client, W83793_REG_CLR_CHASSIS, reg | 0x80); 455 - data->valid = 0; /* Force cache refresh */ 455 + data->valid = false; /* Force cache refresh */ 456 456 mutex_unlock(&data->update_lock); 457 457 return count; 458 458 } ··· 2077 2077 data->vid[1] = w83793_read_value(client, W83793_REG_VID_INB); 2078 2078 w83793_update_nonvolatile(dev); 2079 2079 data->last_updated = jiffies; 2080 - data->valid = 1; 2080 + data->valid = true; 2081 2081 2082 2082 END: 2083 2083 mutex_unlock(&data->update_lock);
+3 -3
drivers/hwmon/w83795.c
··· 379 379 u8 enable_beep; 380 380 u8 beeps[6]; /* Register value */ 381 381 382 - char valid; 382 + bool valid; 383 383 char valid_limits; 384 384 char valid_pwm_config; 385 385 }; ··· 684 684 tmp & ~ALARM_CTRL_RTSACS); 685 685 686 686 data->last_updated = jiffies; 687 - data->valid = 1; 687 + data->valid = true; 688 688 689 689 END: 690 690 mutex_unlock(&data->update_lock); ··· 764 764 765 765 /* Clear status and force cache refresh */ 766 766 w83795_read(client, W83795_REG_ALARM(5)); 767 - data->valid = 0; 767 + data->valid = false; 768 768 mutex_unlock(&data->update_lock); 769 769 return count; 770 770 }
+2 -2
drivers/hwmon/w83l785ts.c
··· 98 98 struct w83l785ts_data { 99 99 struct device *hwmon_dev; 100 100 struct mutex update_lock; 101 - char valid; /* zero until following fields are valid */ 101 + bool valid; /* false until following fields are valid */ 102 102 unsigned long last_updated; /* in jiffies */ 103 103 104 104 /* registers values */ ··· 270 270 W83L785TS_REG_TEMP_OVER, data->temp[1]); 271 271 272 272 data->last_updated = jiffies; 273 - data->valid = 1; 273 + data->valid = true; 274 274 } 275 275 276 276 mutex_unlock(&data->update_lock);
+2 -2
drivers/hwmon/w83l786ng.c
··· 113 113 struct w83l786ng_data { 114 114 struct i2c_client *client; 115 115 struct mutex update_lock; 116 - char valid; /* !=0 if following fields are valid */ 116 + bool valid; /* true if following fields are valid */ 117 117 unsigned long last_updated; /* In jiffies */ 118 118 unsigned long last_nonvolatile; /* In jiffies, last time we update the 119 119 * nonvolatile registers */ ··· 209 209 data->tolerance[1] = (reg_tmp >> 4) & 0x0f; 210 210 211 211 data->last_updated = jiffies; 212 - data->valid = 1; 212 + data->valid = true; 213 213 214 214 } 215 215