Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

The irq_of_parse_and_map() function returns 0 on failure, and does not
return a negative value anyhow, so never enter this conditional branch.

Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/483291/
Link: https://lore.kernel.org/r/20220425090947.3498897-1-lv.ruyi@zte.com.cn
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

authored by

Lv Ruyi and committed by
Dmitry Baryshkov
95093595 3e9c146f

+3 -3
+3 -3
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
··· 1183 1183 priv->kms = &dpu_kms->base; 1184 1184 1185 1185 irq = irq_of_parse_and_map(dpu_kms->pdev->dev.of_node, 0); 1186 - if (irq < 0) { 1187 - DPU_ERROR("failed to get irq: %d\n", irq); 1188 - return irq; 1186 + if (!irq) { 1187 + DPU_ERROR("failed to get irq\n"); 1188 + return -EINVAL; 1189 1189 } 1190 1190 dpu_kms->base.irq = irq; 1191 1191