Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pNFS: Get rid of unnecessary layout parameter in encode_layoutreturn callback

The parameter is already present in the "args" structure.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

+9 -11
+2 -2
fs/nfs/flexfilelayout/flexfilelayout.c
··· 2012 2012 } 2013 2013 2014 2014 static void 2015 - ff_layout_encode_layoutreturn(struct pnfs_layout_hdr *lo, 2016 - struct xdr_stream *xdr, 2015 + ff_layout_encode_layoutreturn(struct xdr_stream *xdr, 2017 2016 const struct nfs4_layoutreturn_args *args) 2018 2017 { 2018 + struct pnfs_layout_hdr *lo = args->layout; 2019 2019 struct nfs4_flexfile_layout *flo = FF_LAYOUT_FROM_HDR(lo); 2020 2020 __be32 *start; 2021 2021
+4 -4
fs/nfs/nfs4xdr.c
··· 2013 2013 const struct nfs4_layoutreturn_args *args, 2014 2014 struct compound_hdr *hdr) 2015 2015 { 2016 + const struct pnfs_layoutdriver_type *lr_ops = NFS_SERVER(args->inode)->pnfs_curr_ld; 2016 2017 __be32 *p; 2017 2018 2018 2019 encode_op_hdr(xdr, OP_LAYOUTRETURN, decode_layoutreturn_maxsz, hdr); ··· 2028 2027 spin_lock(&args->inode->i_lock); 2029 2028 encode_nfs4_stateid(xdr, &args->stateid); 2030 2029 spin_unlock(&args->inode->i_lock); 2031 - if (NFS_SERVER(args->inode)->pnfs_curr_ld->encode_layoutreturn) { 2032 - NFS_SERVER(args->inode)->pnfs_curr_ld->encode_layoutreturn( 2033 - NFS_I(args->inode)->layout, xdr, args); 2034 - } else 2030 + if (lr_ops->encode_layoutreturn) 2031 + lr_ops->encode_layoutreturn(xdr, args); 2032 + else 2035 2033 encode_uint32(xdr, 0); 2036 2034 } 2037 2035
+2 -2
fs/nfs/objlayout/objlayout.c
··· 504 504 } 505 505 506 506 void 507 - objlayout_encode_layoutreturn(struct pnfs_layout_hdr *pnfslay, 508 - struct xdr_stream *xdr, 507 + objlayout_encode_layoutreturn(struct xdr_stream *xdr, 509 508 const struct nfs4_layoutreturn_args *args) 510 509 { 510 + struct pnfs_layout_hdr *pnfslay = args->layout; 511 511 struct objlayout *objlay = OBJLAYOUT(pnfslay); 512 512 struct objlayout_io_res *oir, *tmp; 513 513 __be32 *start;
-1
fs/nfs/objlayout/objlayout.h
··· 175 175 const struct nfs4_layoutcommit_args *); 176 176 177 177 extern void objlayout_encode_layoutreturn( 178 - struct pnfs_layout_hdr *, 179 178 struct xdr_stream *, 180 179 const struct nfs4_layoutreturn_args *); 181 180
+1 -2
fs/nfs/pnfs.h
··· 172 172 (struct nfs_server *server, struct pnfs_device *pdev, 173 173 gfp_t gfp_flags); 174 174 175 - void (*encode_layoutreturn) (struct pnfs_layout_hdr *layoutid, 176 - struct xdr_stream *xdr, 175 + void (*encode_layoutreturn) (struct xdr_stream *xdr, 177 176 const struct nfs4_layoutreturn_args *args); 178 177 179 178 void (*cleanup_layoutcommit) (struct nfs4_layoutcommit_data *data);