Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: tca6416-keypad - replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
int stuff;
struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20200214172022.GA27490@embeddedor
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Gustavo A. R. Silva and committed by
Dmitry Torokhov
94bef5d5 3d87c75d

+2 -2
+2 -2
drivers/input/keyboard/tca6416-keypad.c
··· 33 33 34 34 struct tca6416_drv_data { 35 35 struct input_dev *input; 36 - struct tca6416_button data[0]; 36 + struct tca6416_button data[]; 37 37 }; 38 38 39 39 struct tca6416_keypad_chip { ··· 48 48 int irqnum; 49 49 u16 pinmask; 50 50 bool use_polling; 51 - struct tca6416_button buttons[0]; 51 + struct tca6416_button buttons[]; 52 52 }; 53 53 54 54 static int tca6416_write_reg(struct tca6416_keypad_chip *chip, int reg, u16 val)