Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

driver core: platform: Initialize dma_parms for platform devices

It's currently the platform driver's responsibility to initialize the
pointer, dma_parms, for its corresponding struct device. The benefit with
this approach allows us to avoid the initialization and to not waste memory
for the struct device_dma_parameters, as this can be decided on a case by
case basis.

However, it has turned out that this approach is not very practical. Not
only does it lead to open coding, but also to real errors. In principle
callers of dma_set_max_seg_size() doesn't check the error code, but just
assumes it succeeds.

For these reasons, let's do the initialization from the common platform bus
at the device registration point. This also follows the way the PCI devices
are being managed, see pci_device_add().

Suggested-by: Christoph Hellwig <hch@lst.de>
Cc: <stable@vger.kernel.org>
Tested-by: Haibo Chen <haibo.chen@nxp.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20200422100954.31211-1-ulf.hansson@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Ulf Hansson and committed by
Greg Kroah-Hartman
9495b7e9 6a8b55ed

+3
+2
drivers/base/platform.c
··· 380 380 */ 381 381 static void setup_pdev_dma_masks(struct platform_device *pdev) 382 382 { 383 + pdev->dev.dma_parms = &pdev->dma_parms; 384 + 383 385 if (!pdev->dev.coherent_dma_mask) 384 386 pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); 385 387 if (!pdev->dev.dma_mask) {
+1
include/linux/platform_device.h
··· 25 25 bool id_auto; 26 26 struct device dev; 27 27 u64 platform_dma_mask; 28 + struct device_dma_parameters dma_parms; 28 29 u32 num_resources; 29 30 struct resource *resource; 30 31