Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915/bdw: support GMS and GGMS changes

All the BARs have the ability to grow.

v2: Pulled out the simulator workaround to a separate patch.
Rebased.

v3: Rebase onto latest vlv patches from Jesse.

v4: Rebased on top of the early stolen quirk patch from Jesse.

v5: Use the new macro names.
s/INTEL_BDW_PCI_IDS_D/INTEL_BDW_D_IDS
s/INTEL_BDW_PCI_IDS_M/INTEL_BDW_M_IDS
It's Jesse's fault for not following the convention I originally set.

Cc: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

authored by

Ben Widawsky and committed by
Daniel Vetter
9459d252 4e0bbc31

+42 -3
+12
arch/x86/kernel/early-quirks.c
··· 313 313 return gmch_ctrl << 25; /* 32 MB units */ 314 314 } 315 315 316 + static inline size_t gen8_stolen_size(int num, int slot, int func) 317 + { 318 + u16 gmch_ctrl; 319 + 320 + gmch_ctrl = read_pci_config_16(num, slot, func, SNB_GMCH_CTRL); 321 + gmch_ctrl >>= BDW_GMCH_GMS_SHIFT; 322 + gmch_ctrl &= BDW_GMCH_GMS_MASK; 323 + return gmch_ctrl << 25; /* 32 MB units */ 324 + } 325 + 316 326 typedef size_t (*stolen_size_fn)(int num, int slot, int func); 317 327 318 328 static struct pci_device_id intel_stolen_ids[] __initdata = { ··· 346 336 INTEL_IVB_D_IDS(gen6_stolen_size), 347 337 INTEL_HSW_D_IDS(gen6_stolen_size), 348 338 INTEL_HSW_M_IDS(gen6_stolen_size), 339 + INTEL_BDW_M_IDS(gen8_stolen_size), 340 + INTEL_BDW_D_IDS(gen8_stolen_size) 349 341 }; 350 342 351 343 static void __init intel_graphics_stolen(int num, int slot, int func)
+26 -3
drivers/gpu/drm/i915/i915_gem_gtt.c
··· 869 869 return snb_gmch_ctl << 20; 870 870 } 871 871 872 + static inline unsigned int gen8_get_total_gtt_size(u16 bdw_gmch_ctl) 873 + { 874 + bdw_gmch_ctl >>= BDW_GMCH_GGMS_SHIFT; 875 + bdw_gmch_ctl &= BDW_GMCH_GGMS_MASK; 876 + if (bdw_gmch_ctl) 877 + bdw_gmch_ctl = 1 << bdw_gmch_ctl; 878 + return bdw_gmch_ctl << 20; 879 + } 880 + 872 881 static inline size_t gen6_get_stolen_size(u16 snb_gmch_ctl) 873 882 { 874 883 snb_gmch_ctl >>= SNB_GMCH_GMS_SHIFT; 875 884 snb_gmch_ctl &= SNB_GMCH_GMS_MASK; 876 885 return snb_gmch_ctl << 25; /* 32 MB units */ 886 + } 887 + 888 + static inline size_t gen8_get_stolen_size(u16 bdw_gmch_ctl) 889 + { 890 + bdw_gmch_ctl >>= BDW_GMCH_GMS_SHIFT; 891 + bdw_gmch_ctl &= BDW_GMCH_GMS_MASK; 892 + return bdw_gmch_ctl << 25; /* 32 MB units */ 877 893 } 878 894 879 895 static int gen6_gmch_probe(struct drm_device *dev, ··· 919 903 if (!pci_set_dma_mask(dev->pdev, DMA_BIT_MASK(40))) 920 904 pci_set_consistent_dma_mask(dev->pdev, DMA_BIT_MASK(40)); 921 905 pci_read_config_word(dev->pdev, SNB_GMCH_CTRL, &snb_gmch_ctl); 922 - gtt_size = gen6_get_total_gtt_size(snb_gmch_ctl); 923 906 924 - *stolen = gen6_get_stolen_size(snb_gmch_ctl); 925 - *gtt_total = (gtt_size / sizeof(gen6_gtt_pte_t)) << PAGE_SHIFT; 907 + if (IS_GEN8(dev)) { 908 + gtt_size = gen8_get_total_gtt_size(snb_gmch_ctl); 909 + *gtt_total = (gtt_size / 8) << PAGE_SHIFT; 910 + *stolen = gen8_get_stolen_size(snb_gmch_ctl); 911 + } else { 912 + gtt_size = gen6_get_total_gtt_size(snb_gmch_ctl); 913 + *gtt_total = (gtt_size / sizeof(gen6_gtt_pte_t)) << PAGE_SHIFT; 914 + *stolen = gen6_get_stolen_size(snb_gmch_ctl); 915 + } 926 916 927 917 /* For Modern GENs the PTEs and register space are split in the BAR */ 928 918 gtt_bus_addr = pci_resource_start(dev->pdev, 0) + ··· 938 916 if (!dev_priv->gtt.gsm) { 939 917 DRM_ERROR("Failed to map the gtt page table\n"); 940 918 return -ENOMEM; 919 + 941 920 } 942 921 943 922 ret = setup_scratch_page(dev);
+4
include/drm/i915_drm.h
··· 49 49 #define SNB_GMCH_GGMS_MASK 0x3 50 50 #define SNB_GMCH_GMS_SHIFT 3 /* Graphics Mode Select */ 51 51 #define SNB_GMCH_GMS_MASK 0x1f 52 + #define BDW_GMCH_GGMS_SHIFT 6 53 + #define BDW_GMCH_GGMS_MASK 0x3 54 + #define BDW_GMCH_GMS_SHIFT 8 55 + #define BDW_GMCH_GMS_MASK 0xff 52 56 53 57 #define I830_GMCH_CTRL 0x52 54 58