Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: qixis-fpga: Fix a NULL vs IS_ERR() bug in probe()

The devm_platform_ioremap_resource() function doesn't return NULL, it
returns error pointers. Fix the checking to match.

Fixes: e88500247dc3 ("gpio: add QIXIS FPGA GPIO controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Michael Walle <mwalle@kernel.org>
Link: https://lore.kernel.org/r/aPsaaf0h343Ba7c1@stanley.mountain
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

authored by

Dan Carpenter and committed by
Bartosz Golaszewski
9452252d 96fbc805

+2 -2
+2 -2
drivers/gpio/gpio-qixis-fpga.c
··· 56 56 * create our own from the MMIO space. 57 57 */ 58 58 reg = devm_platform_ioremap_resource(pdev, 0); 59 - if (!reg) 60 - return -ENODEV; 59 + if (IS_ERR(reg)) 60 + return PTR_ERR(reg); 61 61 62 62 regmap = devm_regmap_init_mmio(&pdev->dev, reg, &regmap_config_8r_8v); 63 63 if (!regmap)