USB: ti serial driver sleeps with spinlock held

you are submitting an URB with GFP_KERNEL holding a spinlock.
In this case the spinlock can be dropped earlier.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Cc: Al Borchers <alborchers@steinerpoint.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


authored by Oliver Neukum and committed by Greg Kroah-Hartman 944dc184 8cfbe7e6

+5 -3
+5 -3
drivers/usb/serial/ti_usb_3410_5052.c
··· 1555 1555 spin_lock_irqsave(&tport->tp_lock, flags); 1556 1556 1557 1557 if (tport->tp_read_urb_state == TI_READ_URB_STOPPED) { 1558 + tport->tp_read_urb_state = TI_READ_URB_RUNNING; 1558 1559 urb = tport->tp_port->read_urb; 1560 + spin_unlock_irqrestore(&tport->tp_lock, flags); 1559 1561 urb->complete = ti_bulk_in_callback; 1560 1562 urb->context = tport; 1561 1563 urb->dev = tport->tp_port->serial->dev; 1562 1564 status = usb_submit_urb(urb, GFP_KERNEL); 1565 + } else { 1566 + tport->tp_read_urb_state = TI_READ_URB_RUNNING; 1567 + spin_unlock_irqrestore(&tport->tp_lock, flags); 1563 1568 } 1564 - tport->tp_read_urb_state = TI_READ_URB_RUNNING; 1565 - 1566 - spin_unlock_irqrestore(&tport->tp_lock, flags); 1567 1569 1568 1570 return status; 1569 1571 }