Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: Rework fb_blank()

Reimplement fb_blank() to return early on errors. No functional
changes. Prepares the helper for tracking the blanking state in
struct fb_info.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Simona Vetter <simona.vetter@ffwll.ch>
Link: https://lore.kernel.org/r/20250321095517.313713-2-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org>

authored by

Thomas Zimmermann and committed by
Lee Jones
93e41f96 0af2f6be

+10 -8
+10 -8
drivers/video/fbdev/core/fbmem.c
··· 339 339 } 340 340 EXPORT_SYMBOL(fb_set_var); 341 341 342 - int 343 - fb_blank(struct fb_info *info, int blank) 342 + int fb_blank(struct fb_info *info, int blank) 344 343 { 345 344 struct fb_event event; 346 - int ret = -EINVAL; 345 + int ret; 346 + 347 + if (!info->fbops->fb_blank) 348 + return -EINVAL; 347 349 348 350 if (blank > FB_BLANK_POWERDOWN) 349 351 blank = FB_BLANK_POWERDOWN; ··· 353 351 event.info = info; 354 352 event.data = &blank; 355 353 356 - if (info->fbops->fb_blank) 357 - ret = info->fbops->fb_blank(blank, info); 354 + ret = info->fbops->fb_blank(blank, info); 355 + if (ret) 356 + return ret; 358 357 359 - if (!ret) 360 - fb_notifier_call_chain(FB_EVENT_BLANK, &event); 358 + fb_notifier_call_chain(FB_EVENT_BLANK, &event); 361 359 362 - return ret; 360 + return 0; 363 361 } 364 362 EXPORT_SYMBOL(fb_blank); 365 363