Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/parisc/pdc_stable.c: use WARN

Use WARN rather than printk followed by WARN_ON(1), for conciseness.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Julia Lawall and committed by
Helge Deller
93c3e913 3fad9b8d

+2 -4
+2 -4
drivers/parisc/pdc_stable.c
··· 212 212 entry, devpath, entry->addr); 213 213 214 214 /* addr, devpath and count must be word aligned */ 215 - if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK) { 216 - printk(KERN_ERR "%s: an error occurred when writing to PDC.\n" 215 + if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK) 216 + WARN(1, KERN_ERR "%s: an error occurred when writing to PDC.\n" 217 217 "It is likely that the Stable Storage data has been corrupted.\n" 218 218 "Please check it carefully upon next reboot.\n", __func__); 219 - WARN_ON(1); 220 - } 221 219 222 220 /* kobject is already registered */ 223 221 entry->ready = 2;