Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: s/dev_get_flags/netif_get_flags/

Commit cc34acd577f1 ("docs: net: document new locking reality")
introduced netif_ vs dev_ function semantics: the former expects locked
netdev, the latter takes care of the locking. We don't strictly
follow this semantics on either side, but there are more dev_xxx handlers
now that don't fit. Rename them to netif_xxx where appropriate.

Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250717172333.1288349-6-sdf@fomichev.me
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Stanislav Fomichev and committed by
Jakub Kicinski
93893a57 303a8487

+21 -21
+1 -1
drivers/infiniband/sw/rxe/rxe_verbs.c
··· 65 65 attr->state = ib_get_curr_port_state(ndev); 66 66 if (attr->state == IB_PORT_ACTIVE) 67 67 attr->phys_state = IB_PORT_PHYS_STATE_LINK_UP; 68 - else if (dev_get_flags(ndev) & IFF_UP) 68 + else if (netif_get_flags(ndev) & IFF_UP) 69 69 attr->phys_state = IB_PORT_PHYS_STATE_POLLING; 70 70 else 71 71 attr->phys_state = IB_PORT_PHYS_STATE_DISABLED;
+1 -1
fs/smb/server/smb2pdu.c
··· 7847 7847 if (!ksmbd_find_netdev_name_iface_list(netdev->name)) 7848 7848 continue; 7849 7849 7850 - flags = dev_get_flags(netdev); 7850 + flags = netif_get_flags(netdev); 7851 7851 if (!(flags & IFF_RUNNING)) 7852 7852 continue; 7853 7853 ipv6_retry:
+1 -1
include/linux/netdevice.h
··· 4196 4196 struct kernel_hwtstamp_config *kernel_cfg, 4197 4197 struct netlink_ext_ack *extack); 4198 4198 int dev_ethtool(struct net *net, struct ifreq *ifr, void __user *userdata); 4199 - unsigned int dev_get_flags(const struct net_device *); 4199 + unsigned int netif_get_flags(const struct net_device *dev); 4200 4200 int __dev_change_flags(struct net_device *dev, unsigned int flags, 4201 4201 struct netlink_ext_ack *extack); 4202 4202 int netif_change_flags(struct net_device *dev, unsigned int flags,
+1 -1
net/8021q/vlan.c
··· 483 483 case NETDEV_UP: 484 484 /* Put all VLANs for this dev in the up state too. */ 485 485 vlan_group_for_each_dev(grp, i, vlandev) { 486 - flgs = dev_get_flags(vlandev); 486 + flgs = netif_get_flags(vlandev); 487 487 if (flgs & IFF_UP) 488 488 continue; 489 489
+1 -1
net/bridge/br_netlink.c
··· 479 479 hdr->__ifi_pad = 0; 480 480 hdr->ifi_type = dev->type; 481 481 hdr->ifi_index = dev->ifindex; 482 - hdr->ifi_flags = dev_get_flags(dev); 482 + hdr->ifi_flags = netif_get_flags(dev); 483 483 hdr->ifi_change = 0; 484 484 485 485 if (nla_put_string(skb, IFLA_IFNAME, dev->name) ||
+5 -5
net/core/dev.c
··· 9454 9454 } 9455 9455 9456 9456 /** 9457 - * dev_get_flags - get flags reported to userspace 9458 - * @dev: device 9457 + * netif_get_flags() - get flags reported to userspace 9458 + * @dev: device 9459 9459 * 9460 - * Get the combination of flag bits exported through APIs to userspace. 9460 + * Get the combination of flag bits exported through APIs to userspace. 9461 9461 */ 9462 - unsigned int dev_get_flags(const struct net_device *dev) 9462 + unsigned int netif_get_flags(const struct net_device *dev) 9463 9463 { 9464 9464 unsigned int flags; 9465 9465 ··· 9482 9482 9483 9483 return flags; 9484 9484 } 9485 - EXPORT_SYMBOL(dev_get_flags); 9485 + EXPORT_SYMBOL(netif_get_flags); 9486 9486 9487 9487 int __dev_change_flags(struct net_device *dev, unsigned int flags, 9488 9488 struct netlink_ext_ack *extack)
+1 -1
net/core/dev_ioctl.c
··· 147 147 148 148 switch (cmd) { 149 149 case SIOCGIFFLAGS: /* Get interface flags */ 150 - ifr->ifr_flags = (short) dev_get_flags(dev); 150 + ifr->ifr_flags = (short)netif_get_flags(dev); 151 151 return 0; 152 152 153 153 case SIOCGIFMETRIC: /* Get the metric on the interface
+2 -2
net/core/rtnetlink.c
··· 2038 2038 ifm->__ifi_pad = 0; 2039 2039 ifm->ifi_type = READ_ONCE(dev->type); 2040 2040 ifm->ifi_index = READ_ONCE(dev->ifindex); 2041 - ifm->ifi_flags = dev_get_flags(dev); 2041 + ifm->ifi_flags = netif_get_flags(dev); 2042 2042 ifm->ifi_change = change; 2043 2043 2044 2044 if (tgt_netnsid >= 0 && nla_put_s32(skb, IFLA_TARGET_NETNSID, tgt_netnsid)) ··· 5227 5227 ifm->__ifi_pad = 0; 5228 5228 ifm->ifi_type = dev->type; 5229 5229 ifm->ifi_index = dev->ifindex; 5230 - ifm->ifi_flags = dev_get_flags(dev); 5230 + ifm->ifi_flags = netif_get_flags(dev); 5231 5231 ifm->ifi_change = 0; 5232 5232 5233 5233
+1 -1
net/ipv4/fib_frontend.c
··· 1524 1524 fib_disable_ip(dev, event, false); 1525 1525 break; 1526 1526 case NETDEV_CHANGE: 1527 - flags = dev_get_flags(dev); 1527 + flags = netif_get_flags(dev); 1528 1528 if (flags & (IFF_RUNNING | IFF_LOWER_UP)) 1529 1529 fib_sync_up(dev, RTNH_F_LINKDOWN); 1530 1530 else
+1 -1
net/ipv4/fib_semantics.c
··· 2087 2087 return 0; 2088 2088 2089 2089 if (nh_flags & RTNH_F_DEAD) { 2090 - unsigned int flags = dev_get_flags(dev); 2090 + unsigned int flags = netif_get_flags(dev); 2091 2091 2092 2092 if (flags & (IFF_RUNNING | IFF_LOWER_UP)) 2093 2093 nh_flags |= RTNH_F_LINKDOWN;
+1 -1
net/ipv4/nexthop.c
··· 3884 3884 nexthop_flush_dev(dev, event); 3885 3885 break; 3886 3886 case NETDEV_CHANGE: 3887 - if (!(dev_get_flags(dev) & (IFF_RUNNING | IFF_LOWER_UP))) 3887 + if (!(netif_get_flags(dev) & (IFF_RUNNING | IFF_LOWER_UP))) 3888 3888 nexthop_flush_dev(dev, event); 3889 3889 break; 3890 3890 case NETDEV_CHANGEMTU:
+1 -1
net/ipv6/addrconf.c
··· 6072 6072 hdr->ifi_type = dev->type; 6073 6073 ifindex = READ_ONCE(dev->ifindex); 6074 6074 hdr->ifi_index = ifindex; 6075 - hdr->ifi_flags = dev_get_flags(dev); 6075 + hdr->ifi_flags = netif_get_flags(dev); 6076 6076 hdr->ifi_change = 0; 6077 6077 6078 6078 iflink = dev_get_iflink(dev);
+3 -3
net/mpls/af_mpls.c
··· 706 706 } else { 707 707 unsigned int flags; 708 708 709 - flags = dev_get_flags(dev); 709 + flags = netif_get_flags(dev); 710 710 if (!(flags & (IFF_RUNNING | IFF_LOWER_UP))) 711 711 nh->nh_flags |= RTNH_F_LINKDOWN; 712 712 } ··· 1616 1616 return notifier_from_errno(err); 1617 1617 break; 1618 1618 case NETDEV_UP: 1619 - flags = dev_get_flags(dev); 1619 + flags = netif_get_flags(dev); 1620 1620 if (flags & (IFF_RUNNING | IFF_LOWER_UP)) 1621 1621 mpls_ifup(dev, RTNH_F_DEAD | RTNH_F_LINKDOWN); 1622 1622 else 1623 1623 mpls_ifup(dev, RTNH_F_DEAD); 1624 1624 break; 1625 1625 case NETDEV_CHANGE: 1626 - flags = dev_get_flags(dev); 1626 + flags = netif_get_flags(dev); 1627 1627 if (flags & (IFF_RUNNING | IFF_LOWER_UP)) { 1628 1628 mpls_ifup(dev, RTNH_F_DEAD | RTNH_F_LINKDOWN); 1629 1629 } else {
+1 -1
net/wireless/wext-core.c
··· 431 431 r->__ifi_pad = 0; 432 432 r->ifi_type = dev->type; 433 433 r->ifi_index = dev->ifindex; 434 - r->ifi_flags = dev_get_flags(dev); 434 + r->ifi_flags = netif_get_flags(dev); 435 435 r->ifi_change = 0; /* Wireless changes don't affect those flags */ 436 436 437 437 if (nla_put_string(skb, IFLA_IFNAME, dev->name))