Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sparc: fix accurate exception reporting in copy_{from,to}_user for M7

The referenced commit introduced exception handlers on user-space memory
references in copy_from_user and copy_to_user. These handlers return from
the respective function and calculate the remaining bytes left to copy
using the current register contents. This commit fixes a couple of bad
calculations. This will fix the return value of copy_from_user and
copy_to_user in the faulting case. The behaviour of memcpy stays unchanged.

Fixes: 34060b8fffa7 ("arch/sparc: Add accurate exception reporting in M7memcpy")
Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> # on Oracle SPARC S7
Tested-by: Tony Rodriguez <unixpro1970@gmail.com> # S7, see https://lore.kernel.org/r/98564e2e68df2dda0e00c67a75c7f7dfedb33c7e.camel@physik.fu-berlin.de
Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Link: https://lore.kernel.org/r/20250905-memcpy_series-v4-5-1ca72dda195b@mkarcher.dialup.fu-berlin.de
Signed-off-by: Andreas Larsson <andreas@gaisler.com>

authored by

Michael Karcher and committed by
Andreas Larsson
936fb512 5a746c1a

+19 -10
+10 -10
arch/sparc/lib/M7memcpy.S
··· 696 696 EX_LD_FP(LOAD(ldd, %o4+40, %f26), memcpy_retl_o2_plus_o5_plus_40) 697 697 faligndata %f24, %f26, %f10 698 698 EX_ST_FP(STORE(std, %f6, %o0+24), memcpy_retl_o2_plus_o5_plus_40) 699 - EX_LD_FP(LOAD(ldd, %o4+48, %f28), memcpy_retl_o2_plus_o5_plus_40) 699 + EX_LD_FP(LOAD(ldd, %o4+48, %f28), memcpy_retl_o2_plus_o5_plus_32) 700 700 faligndata %f26, %f28, %f12 701 - EX_ST_FP(STORE(std, %f8, %o0+32), memcpy_retl_o2_plus_o5_plus_40) 701 + EX_ST_FP(STORE(std, %f8, %o0+32), memcpy_retl_o2_plus_o5_plus_32) 702 702 add %o4, 64, %o4 703 - EX_LD_FP(LOAD(ldd, %o4-8, %f30), memcpy_retl_o2_plus_o5_plus_40) 703 + EX_LD_FP(LOAD(ldd, %o4-8, %f30), memcpy_retl_o2_plus_o5_plus_24) 704 704 faligndata %f28, %f30, %f14 705 - EX_ST_FP(STORE(std, %f10, %o0+40), memcpy_retl_o2_plus_o5_plus_40) 706 - EX_ST_FP(STORE(std, %f12, %o0+48), memcpy_retl_o2_plus_o5_plus_40) 705 + EX_ST_FP(STORE(std, %f10, %o0+40), memcpy_retl_o2_plus_o5_plus_24) 706 + EX_ST_FP(STORE(std, %f12, %o0+48), memcpy_retl_o2_plus_o5_plus_16) 707 707 add %o0, 64, %o0 708 - EX_ST_FP(STORE(std, %f14, %o0-8), memcpy_retl_o2_plus_o5_plus_40) 708 + EX_ST_FP(STORE(std, %f14, %o0-8), memcpy_retl_o2_plus_o5_plus_8) 709 709 fsrc2 %f30, %f14 710 710 bgu,pt %xcc, .Lunalign_sloop 711 711 prefetch [%o4 + (8 * BLOCK_SIZE)], 20 ··· 728 728 add %o4, 8, %o4 729 729 faligndata %f0, %f2, %f16 730 730 subcc %o5, 8, %o5 731 - EX_ST_FP(STORE(std, %f16, %o0), memcpy_retl_o2_plus_o5) 731 + EX_ST_FP(STORE(std, %f16, %o0), memcpy_retl_o2_plus_o5_plus_8) 732 732 fsrc2 %f2, %f0 733 733 bgu,pt %xcc, .Lunalign_by8 734 734 add %o0, 8, %o0 ··· 772 772 subcc %o5, 0x20, %o5 773 773 EX_ST(STORE(stx, %o3, %o0 + 0x00), memcpy_retl_o2_plus_o5_plus_32) 774 774 EX_ST(STORE(stx, %g2, %o0 + 0x08), memcpy_retl_o2_plus_o5_plus_24) 775 - EX_ST(STORE(stx, %g7, %o0 + 0x10), memcpy_retl_o2_plus_o5_plus_24) 775 + EX_ST(STORE(stx, %g7, %o0 + 0x10), memcpy_retl_o2_plus_o5_plus_16) 776 776 EX_ST(STORE(stx, %o4, %o0 + 0x18), memcpy_retl_o2_plus_o5_plus_8) 777 777 bne,pt %xcc, 1b 778 778 add %o0, 0x20, %o0 ··· 804 804 brz,pt %o3, 2f 805 805 sub %o2, %o3, %o2 806 806 807 - 1: EX_LD(LOAD(ldub, %o1 + 0x00, %g2), memcpy_retl_o2_plus_g1) 807 + 1: EX_LD(LOAD(ldub, %o1 + 0x00, %g2), memcpy_retl_o2_plus_o3) 808 808 add %o1, 1, %o1 809 809 subcc %o3, 1, %o3 810 810 add %o0, 1, %o0 811 811 bne,pt %xcc, 1b 812 - EX_ST(STORE(stb, %g2, %o0 - 0x01), memcpy_retl_o2_plus_g1_plus_1) 812 + EX_ST(STORE(stb, %g2, %o0 - 0x01), memcpy_retl_o2_plus_o3_plus_1) 813 813 2: 814 814 and %o1, 0x7, %o3 815 815 brz,pn %o3, .Lmedium_noprefetch_cp
+9
arch/sparc/lib/Memcpy_utils.S
··· 137 137 ba,pt %xcc, __restore_asi 138 138 add %o2, 8, %o0 139 139 ENDPROC(memcpy_retl_o2_plus_63_8) 140 + ENTRY(memcpy_retl_o2_plus_o3) 141 + ba,pt %xcc, __restore_asi 142 + add %o2, %o3, %o0 143 + ENDPROC(memcpy_retl_o2_plus_o3) 144 + ENTRY(memcpy_retl_o2_plus_o3_plus_1) 145 + add %o3, 1, %o3 146 + ba,pt %xcc, __restore_asi 147 + add %o2, %o3, %o0 148 + ENDPROC(memcpy_retl_o2_plus_o3_plus_1) 140 149 ENTRY(memcpy_retl_o2_plus_o5) 141 150 ba,pt %xcc, __restore_asi 142 151 add %o2, %o5, %o0