Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: reorganize urb->status use in usbmon

This patch (as978) reorganizes the way usbmon uses urb->status. It
now accepts the status value as an argument.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Alan Stern and committed by
Greg Kroah-Hartman
9347d51c 888fda47

+24 -21
+1 -1
drivers/usb/core/hcd.c
··· 1275 1275 urb->status = -EREMOTEIO; 1276 1276 1277 1277 unmap_urb_for_dma(hcd, urb); 1278 - usbmon_urb_complete(&hcd->self, urb); 1278 + usbmon_urb_complete(&hcd->self, urb, urb->status); 1279 1279 usb_unanchor_urb(urb); 1280 1280 1281 1281 /* pass ownership to the completion handler */
+6 -4
drivers/usb/core/hcd.h
··· 413 413 struct usb_mon_operations { 414 414 void (*urb_submit)(struct usb_bus *bus, struct urb *urb); 415 415 void (*urb_submit_error)(struct usb_bus *bus, struct urb *urb, int err); 416 - void (*urb_complete)(struct usb_bus *bus, struct urb *urb); 416 + void (*urb_complete)(struct usb_bus *bus, struct urb *urb, int status); 417 417 /* void (*urb_unlink)(struct usb_bus *bus, struct urb *urb); */ 418 418 }; 419 419 ··· 432 432 (*mon_ops->urb_submit_error)(bus, urb, error); 433 433 } 434 434 435 - static inline void usbmon_urb_complete(struct usb_bus *bus, struct urb *urb) 435 + static inline void usbmon_urb_complete(struct usb_bus *bus, struct urb *urb, 436 + int status) 436 437 { 437 438 if (bus->monitored) 438 - (*mon_ops->urb_complete)(bus, urb); 439 + (*mon_ops->urb_complete)(bus, urb, status); 439 440 } 440 441 441 442 int usb_mon_register(struct usb_mon_operations *ops); ··· 447 446 static inline void usbmon_urb_submit(struct usb_bus *bus, struct urb *urb) {} 448 447 static inline void usbmon_urb_submit_error(struct usb_bus *bus, struct urb *urb, 449 448 int error) {} 450 - static inline void usbmon_urb_complete(struct usb_bus *bus, struct urb *urb) {} 449 + static inline void usbmon_urb_complete(struct usb_bus *bus, struct urb *urb, 450 + int status) {} 451 451 452 452 #endif /* CONFIG_USB_MON */ 453 453
+5 -5
drivers/usb/mon/mon_bin.c
··· 386 386 } 387 387 388 388 static void mon_bin_event(struct mon_reader_bin *rp, struct urb *urb, 389 - char ev_type) 389 + char ev_type, int status) 390 390 { 391 391 const struct usb_endpoint_descriptor *epd = &urb->ep->desc; 392 392 unsigned long flags; ··· 452 452 ep->id = (unsigned long) urb; 453 453 ep->ts_sec = ts.tv_sec; 454 454 ep->ts_usec = ts.tv_usec; 455 - ep->status = urb->status; 455 + ep->status = status; 456 456 ep->len_urb = urb_length; 457 457 ep->len_cap = length; 458 458 ··· 475 475 static void mon_bin_submit(void *data, struct urb *urb) 476 476 { 477 477 struct mon_reader_bin *rp = data; 478 - mon_bin_event(rp, urb, 'S'); 478 + mon_bin_event(rp, urb, 'S', -EINPROGRESS); 479 479 } 480 480 481 - static void mon_bin_complete(void *data, struct urb *urb) 481 + static void mon_bin_complete(void *data, struct urb *urb, int status) 482 482 { 483 483 struct mon_reader_bin *rp = data; 484 - mon_bin_event(rp, urb, 'C'); 484 + mon_bin_event(rp, urb, 'C', status); 485 485 } 486 486 487 487 static void mon_bin_error(void *data, struct urb *urb, int error)
+6 -5
drivers/usb/mon/mon_main.c
··· 129 129 130 130 /* 131 131 */ 132 - static void mon_bus_complete(struct mon_bus *mbus, struct urb *urb) 132 + static void mon_bus_complete(struct mon_bus *mbus, struct urb *urb, 133 + int status) 133 134 { 134 135 unsigned long flags; 135 136 struct list_head *pos; ··· 140 139 mbus->cnt_events++; 141 140 list_for_each (pos, &mbus->r_list) { 142 141 r = list_entry(pos, struct mon_reader, r_link); 143 - r->rnf_complete(r->r_data, urb); 142 + r->rnf_complete(r->r_data, urb, status); 144 143 } 145 144 spin_unlock_irqrestore(&mbus->lock, flags); 146 145 } 147 146 148 - static void mon_complete(struct usb_bus *ubus, struct urb *urb) 147 + static void mon_complete(struct usb_bus *ubus, struct urb *urb, int status) 149 148 { 150 149 struct mon_bus *mbus; 151 150 152 151 if ((mbus = ubus->mon_bus) != NULL) 153 - mon_bus_complete(mbus, urb); 154 - mon_bus_complete(&mon_bus0, urb); 152 + mon_bus_complete(mbus, urb, status); 153 + mon_bus_complete(&mon_bus0, urb, status); 155 154 } 156 155 157 156 /* int (*unlink_urb) (struct urb *urb, int status); */
+5 -5
drivers/usb/mon/mon_text.c
··· 183 183 } 184 184 185 185 static void mon_text_event(struct mon_reader_text *rp, struct urb *urb, 186 - char ev_type) 186 + char ev_type, int status) 187 187 { 188 188 struct mon_event_text *ep; 189 189 unsigned int stamp; ··· 210 210 ep->length = (ev_type == 'S') ? 211 211 urb->transfer_buffer_length : urb->actual_length; 212 212 /* Collecting status makes debugging sense for submits, too */ 213 - ep->status = urb->status; 213 + ep->status = status; 214 214 215 215 if (ep->xfertype == USB_ENDPOINT_XFER_INT) { 216 216 ep->interval = urb->interval; ··· 248 248 static void mon_text_submit(void *data, struct urb *urb) 249 249 { 250 250 struct mon_reader_text *rp = data; 251 - mon_text_event(rp, urb, 'S'); 251 + mon_text_event(rp, urb, 'S', -EINPROGRESS); 252 252 } 253 253 254 - static void mon_text_complete(void *data, struct urb *urb) 254 + static void mon_text_complete(void *data, struct urb *urb, int status) 255 255 { 256 256 struct mon_reader_text *rp = data; 257 - mon_text_event(rp, urb, 'C'); 257 + mon_text_event(rp, urb, 'C', status); 258 258 } 259 259 260 260 static void mon_text_error(void *data, struct urb *urb, int error)
+1 -1
drivers/usb/mon/usb_mon.h
··· 46 46 47 47 void (*rnf_submit)(void *data, struct urb *urb); 48 48 void (*rnf_error)(void *data, struct urb *urb, int error); 49 - void (*rnf_complete)(void *data, struct urb *urb); 49 + void (*rnf_complete)(void *data, struct urb *urb, int status); 50 50 }; 51 51 52 52 void mon_reader_add(struct mon_bus *mbus, struct mon_reader *r);