tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch
This is part of an effort to clean-up the MFD subsystem.
ERROR: space required before the open parenthesis '('
+ if(!micro->msg)
WARNING: unnecessary whitespace before a quoted newline
+ dev_dbg(micro->dev, "key message ignored, no handle \n");
WARNING: unnecessary whitespace before a quoted newline
+ dev_dbg(micro->dev, "touchscreen message ignored, no handle \n");
WARNING: space prohibited before semicolon
+ rx->id = (ch & 0xf0) >> 4 ;
total: 1 errors, 3 warnings, 482 lines checked
Signed-off-by: Lee Jones <lee.jones@linaro.org>
+4
-4
+4
-4
drivers/mfd/ipaq-micro.c
+4
-4
drivers/mfd/ipaq-micro.c
···
115
115
} else {
116
116
dev_err(micro->dev,
117
117
"out of band RX message 0x%02x\n", id);
118
-
if(!micro->msg)
118
+
if (!micro->msg)
119
119
dev_info(micro->dev, "no message queued\n");
120
120
else
121
121
dev_info(micro->dev, "expected message %02x\n",
···
126
126
if (micro->key)
127
127
micro->key(micro->key_data, len, data);
128
128
else
129
-
dev_dbg(micro->dev, "key message ignored, no handle \n");
129
+
dev_dbg(micro->dev, "key message ignored, no handle\n");
130
130
break;
131
131
case MSG_TOUCHSCREEN:
132
132
if (micro->ts)
133
133
micro->ts(micro->ts_data, len, data);
134
134
else
135
-
dev_dbg(micro->dev, "touchscreen message ignored, no handle \n");
135
+
dev_dbg(micro->dev, "touchscreen message ignored, no handle\n");
136
136
break;
137
137
default:
138
138
dev_err(micro->dev,
···
154
154
rx->state = STATE_ID; /* Next byte is the id and len */
155
155
break;
156
156
case STATE_ID: /* Looking for id and len byte */
157
-
rx->id = (ch & 0xf0) >> 4 ;
157
+
rx->id = (ch & 0xf0) >> 4;
158
158
rx->len = (ch & 0x0f);
159
159
rx->index = 0;
160
160
rx->chksum = ch;