Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: wm8904: harmless underflow in wm8904_put_deemph()

We try to check that "deemph" is zero or one, but because of an
underflow bug, it can also be negative. It's fine, negative values are
handled as non-zero. But it's messy and static checkers complain so
let's fix it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Dan Carpenter and committed by
Mark Brown
931dfa69 6ff33f39

+1 -1
+1 -1
sound/soc/codecs/wm8904.c
··· 534 534 { 535 535 struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); 536 536 struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec); 537 - int deemph = ucontrol->value.integer.value[0]; 537 + unsigned int deemph = ucontrol->value.integer.value[0]; 538 538 539 539 if (deemph > 1) 540 540 return -EINVAL;