Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: cw2015: Check devm_delayed_work_autocancel() return code

Since devm_delayed_work_autocancel() may fail, add return code check and
exit cw_bat_probe() on error.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 0cb172a4918e ("power: supply: cw2015: Use device managed API to simplify the code")
Signed-off-by: Ivan Abramov <i.abramov@mt-integration.ru>
Link: https://patch.msgid.link/20251008120711.556021-1-i.abramov@mt-integration.ru
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Ivan Abramov and committed by
Sebastian Reichel
92ec7e7b 6cdc4d48

+7 -1
+7 -1
drivers/power/supply/cw2015_battery.c
··· 699 699 if (!cw_bat->battery_workqueue) 700 700 return -ENOMEM; 701 701 702 - devm_delayed_work_autocancel(&client->dev, &cw_bat->battery_delay_work, cw_bat_work); 702 + ret = devm_delayed_work_autocancel(&client->dev, &cw_bat->battery_delay_work, cw_bat_work); 703 + if (ret) { 704 + dev_err_probe(&client->dev, ret, 705 + "Failed to register delayed work\n"); 706 + return ret; 707 + } 708 + 703 709 queue_delayed_work(cw_bat->battery_workqueue, 704 710 &cw_bat->battery_delay_work, msecs_to_jiffies(10)); 705 711 return 0;