Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

can: sja1000_isa: sja1000_isa_probe(): add missing free_sja1000dev()

Add the missing free_sja1000dev() before return from
sja1000_isa_probe() in the register_sja1000dev() error handling case.

In addition, remove blanks before goto labels.

Fixes: 2a6ba39ad6a2 ("can: sja1000: legacy SJA1000 ISA bus driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/all/1668168521-5540-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

authored by

Zhang Changzhong and committed by
Marc Kleine-Budde
92dfd931 26e8f6a7

+6 -4
+6 -4
drivers/net/can/sja1000/sja1000_isa.c
··· 202 202 if (err) { 203 203 dev_err(&pdev->dev, "registering %s failed (err=%d)\n", 204 204 DRV_NAME, err); 205 - goto exit_unmap; 205 + goto exit_free; 206 206 } 207 207 208 208 dev_info(&pdev->dev, "%s device registered (reg_base=0x%p, irq=%d)\n", 209 209 DRV_NAME, priv->reg_base, dev->irq); 210 210 return 0; 211 211 212 - exit_unmap: 212 + exit_free: 213 + free_sja1000dev(dev); 214 + exit_unmap: 213 215 if (mem[idx]) 214 216 iounmap(base); 215 - exit_release: 217 + exit_release: 216 218 if (mem[idx]) 217 219 release_mem_region(mem[idx], iosize); 218 220 else 219 221 release_region(port[idx], iosize); 220 - exit: 222 + exit: 221 223 return err; 222 224 } 223 225