Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: prox: isl29501: Fix buffer alignment in iio_push_to_buffers_with_timestamp()

Add __aligned(8) to ensure the buffer passed to
iio_push_to_buffers_with_timestamp() is suitable for the naturally
aligned timestamp that will be inserted.

Here an explicit structure is not used, because the holes would
necessitate the addition of an explict memset(), to avoid a kernel
data leak, making for a less minimal fix.

Fixes: 1c28799257bc ("iio: light: isl29501: Add support for the ISL29501 ToF sensor.")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Mathieu Othacehe <m.othacehe@gmail.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210613152301.571002-9-jic23@kernel.org

+1 -1
+1 -1
drivers/iio/proximity/isl29501.c
··· 938 938 struct iio_dev *indio_dev = pf->indio_dev; 939 939 struct isl29501_private *isl29501 = iio_priv(indio_dev); 940 940 const unsigned long *active_mask = indio_dev->active_scan_mask; 941 - u32 buffer[4] = {}; /* 1x16-bit + ts */ 941 + u32 buffer[4] __aligned(8) = {}; /* 1x16-bit + naturally aligned ts */ 942 942 943 943 if (test_bit(ISL29501_DISTANCE_SCAN_INDEX, active_mask)) 944 944 isl29501_register_read(isl29501, REG_DISTANCE, buffer);