Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARC: mm: do_page_fault refactor #8: release mmap_sem sooner

In case of successful page fault handling, this patch releases mmap_sem
before updating the perf stat event for major/minor faults. So even
though the contention reduction is NOT super high, it is still an
improvement.

There's an additional code size improvement as we only have 2 up_read()
calls now.

Note to myself:
--------------

1. Given the way it is done, we are forced to move @bad_area label earlier
causing the various "goto bad_area" cases to hit perf stat code.

- PERF_COUNT_SW_PAGE_FAULTS is NOW updated for access errors which is what
arm/arm64 seem to be doing as well (with slightly different code)
- PERF_COUNT_SW_PAGE_FAULTS_{MAJ,MIN} must NOT be updated for the
error case which is guarded by now setting @fault initial value
to VM_FAULT_ERROR which serves both cases when handle_mm_fault()
returns error or is not called at all.

2. arm/arm64 use two homebrew fault flags VM_FAULT_BAD{MAP,MAPACCESS}
which I was inclined to add too but seems not needed for ARC

- given that we have everything is 1 function we can still use goto
- we setup si_code at the right place (arm* do that in the end)
- we init fault already to error value which guards entry into perf
stats event update

Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>

+3 -4
+3 -4
arch/arc/mm/fault.c
··· 152 152 } 153 153 } 154 154 155 + bad_area: 156 + up_read(&mm->mmap_sem); 157 + 155 158 /* 156 159 * Major/minor page fault accounting 157 160 * (in case of retry we only land here once) ··· 173 170 } 174 171 175 172 /* Normal return path: fault Handled Gracefully */ 176 - up_read(&mm->mmap_sem); 177 173 return; 178 174 } 179 - 180 - bad_area: 181 - up_read(&mm->mmap_sem); 182 175 183 176 if (!user_mode(regs)) 184 177 goto no_context;