Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: net: add more info to error in bpf_offload

bpf_offload caught a spurious warning in TC recently, but the error
message did not provide enough information to know what the problem
is:

FAIL: Found 'netdevsim' in command output, leaky extack?

Add the extack to the output:

FAIL: Unexpected command output, leaky extack? ('netdevsim', 'Warning: Filter with specified priority/protocol not found.')

Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

+3 -2
+3 -2
tools/testing/selftests/net/bpf_offload.py
··· 594 594 check_extack(output, "netdevsim: " + reference, args) 595 595 596 596 def check_no_extack(res, needle): 597 - fail((res[1] + res[2]).count(needle) or (res[1] + res[2]).count("Warning:"), 598 - "Found '%s' in command output, leaky extack?" % (needle)) 597 + haystack = (res[1] + res[2]).strip() 598 + fail(haystack.count(needle) or haystack.count("Warning:"), 599 + "Unexpected command output, leaky extack? ('%s', '%s')" % (needle, haystack)) 599 600 600 601 def check_verifier_log(output, reference): 601 602 lines = output.split("\n")