Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

thermal/drivers/qoriq: Use dev_err_probe() simplify the code

Use dev_err_probe() and devm_clk_get_optional_enabled() to simplify the
code.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20241209164859.3758906-1-Frank.Li@nxp.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

authored by

Frank Li and committed by
Daniel Lezcano
92009c3b c3b659b7

+10 -24
+10 -24
drivers/thermal/qoriq_thermal.c
··· 265 265 struct qoriq_tmu_data *data = p; 266 266 267 267 regmap_write(data->regmap, REGS_TMR, TMR_DISABLE); 268 - clk_disable_unprepare(data->clk); 269 268 } 270 269 271 270 static int qoriq_tmu_probe(struct platform_device *pdev) ··· 295 296 296 297 base = devm_platform_ioremap_resource(pdev, 0); 297 298 ret = PTR_ERR_OR_ZERO(base); 298 - if (ret) { 299 - dev_err(dev, "Failed to get memory region\n"); 300 - return ret; 301 - } 299 + if (ret) 300 + return dev_err_probe(dev, ret, "Failed to get memory region\n"); 302 301 303 302 data->regmap = devm_regmap_init_mmio(dev, base, &regmap_config); 304 303 ret = PTR_ERR_OR_ZERO(data->regmap); 305 - if (ret) { 306 - dev_err(dev, "Failed to init regmap (%d)\n", ret); 307 - return ret; 308 - } 304 + if (ret) 305 + return dev_err_probe(dev, ret, "Failed to init regmap\n"); 309 306 310 - data->clk = devm_clk_get_optional(dev, NULL); 307 + data->clk = devm_clk_get_optional_enabled(dev, NULL); 311 308 if (IS_ERR(data->clk)) 312 309 return PTR_ERR(data->clk); 313 - 314 - ret = clk_prepare_enable(data->clk); 315 - if (ret) { 316 - dev_err(dev, "Failed to enable clock\n"); 317 - return ret; 318 - } 319 310 320 311 ret = devm_add_action_or_reset(dev, qoriq_tmu_action, data); 321 312 if (ret) ··· 313 324 314 325 /* version register offset at: 0xbf8 on both v1 and v2 */ 315 326 ret = regmap_read(data->regmap, REGS_IPBRR(0), &ver); 316 - if (ret) { 317 - dev_err(&pdev->dev, "Failed to read IP block version\n"); 318 - return ret; 319 - } 327 + if (ret) 328 + return dev_err_probe(dev, ret, "Failed to read IP block version\n"); 329 + 320 330 data->ver = (ver >> 8) & 0xff; 321 331 322 332 qoriq_tmu_init_device(data); /* TMU initialization */ ··· 325 337 return ret; 326 338 327 339 ret = qoriq_tmu_register_tmu_zone(dev, data); 328 - if (ret < 0) { 329 - dev_err(dev, "Failed to register sensors\n"); 330 - return ret; 331 - } 340 + if (ret < 0) 341 + return dev_err_probe(dev, ret, "Failed to register sensors\n"); 332 342 333 343 platform_set_drvdata(pdev, data); 334 344