Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

MIPS, Perf-events: Work with irq_work

This is the MIPS part of the following commit by Peter Zijlstra:

- e360adbe29241a0194e10e20595360dd7b98a2b3
irq_work: Add generic hardirq context callbacks

Provide a mechanism that allows running code in IRQ context. It is
most useful for NMI code that needs to interact with the rest of the
system -- like wakeup a task to drain buffers.

Perf currently has such a mechanism, so extract that and provide it as
a generic feature, independent of perf so that others may also
benefit.

The IRQ context callback is generated through self-IPIs where
possible, or on architectures like powerpc the decrementer (the
built-in timer facility) is set to generate an interrupt immediately.

Architectures that don't have anything like this get to do with a
callback from the timer tick. These architectures can call
irq_work_run() at the tail of any IRQ handlers that might enqueue such
work (like the perf IRQ handler) to avoid undue latencies in
processing the work.

For MIPSXX, we need to call irq_work_run() at the tail of the perf IRQ
handler as described above.

Reported-by: Wu Zhangjin <wuzhangjin@gmail.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
To: fweisbec@gmail.com
To: will.deacon@arm.com
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: paulus@samba.org
Cc: mingo@elte.hu
Cc: acme@redhat.com
Cc: matt@console-pimps.org
Cc: sshtylyov@mvista.com,
Patchwork: http://patchwork.linux-mips.org/patch/2011/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

authored by

Deng-Cheng Zhu and committed by
Ralf Baechle
91f01737 efe8dc55

+3 -12
+1
arch/mips/Kconfig
··· 4 4 select HAVE_GENERIC_DMA_COHERENT 5 5 select HAVE_IDE 6 6 select HAVE_OPROFILE 7 + select HAVE_IRQ_WORK 7 8 select HAVE_PERF_EVENTS 8 9 select PERF_USE_VMALLOC 9 10 select HAVE_ARCH_KGDB
+1 -11
arch/mips/include/asm/perf_event.h
··· 11 11 12 12 #ifndef __MIPS_PERF_EVENT_H__ 13 13 #define __MIPS_PERF_EVENT_H__ 14 - 15 - /* 16 - * MIPS performance counters do not raise NMI upon overflow, a regular 17 - * interrupt will be signaled. Hence we can do the pending perf event 18 - * work at the tail of the irq handler. 19 - */ 20 - static inline void 21 - set_perf_event_pending(void) 22 - { 23 - } 24 - 14 + /* Leave it empty here. The file is required by linux/perf_event.h */ 25 15 #endif /* __MIPS_PERF_EVENT_H__ */
+1 -1
arch/mips/kernel/perf_event_mipsxx.c
··· 696 696 * interrupt, not NMI. 697 697 */ 698 698 if (handled == IRQ_HANDLED) 699 - perf_event_do_pending(); 699 + irq_work_run(); 700 700 701 701 #ifdef CONFIG_MIPS_MT_SMP 702 702 read_unlock(&pmuint_rwlock);