[PATCH] gpio: drop vtable members .gpio_set_high .gpio_set_low gpio_set is enough

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

drops gpio_set_high, gpio_set_low from the nsc_gpio_ops vtable. While we
can't drop them from scx200_gpio (or can we?), we dont need them for new users
of the exported vtable; gpio_set(1), gpio_set(0) work fine.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Jim Cromie and committed by

Linus Torvalds 20 years ago 91e260b8 b9432e4d

-6

3 changed files

expand all

drivers

char

pc8736x_gpio.c

scx200_gpio.c

include

linux

nsc_gpio.h

-2

drivers/char/pc8736x_gpio.c

··· 218 218 .gpio_dump = nsc_gpio_dump, 219 219 .gpio_get = pc8736x_gpio_get, 220 220 .gpio_set = pc8736x_gpio_set, 221 - .gpio_set_high = pc8736x_gpio_set_high, 222 - .gpio_set_low = pc8736x_gpio_set_low, 223 221 .gpio_change = pc8736x_gpio_change, 224 222 .gpio_current = pc8736x_gpio_current 225 223 };

-2

drivers/char/scx200_gpio.c

··· 41 41 .gpio_dump = nsc_gpio_dump, 42 42 .gpio_get = scx200_gpio_get, 43 43 .gpio_set = scx200_gpio_set, 44 - .gpio_set_high = scx200_gpio_set_high, 45 - .gpio_set_low = scx200_gpio_set_low, 46 44 .gpio_change = scx200_gpio_change, 47 45 .gpio_current = scx200_gpio_current 48 46 };

-2

include/linux/nsc_gpio.h

··· 25 25 void (*gpio_dump) (struct nsc_gpio_ops *amp, unsigned iminor); 26 26 int (*gpio_get) (unsigned iminor); 27 27 void (*gpio_set) (unsigned iminor, int state); 28 - void (*gpio_set_high)(unsigned iminor); 29 - void (*gpio_set_low) (unsigned iminor); 30 28 void (*gpio_change) (unsigned iminor); 31 29 int (*gpio_current) (unsigned iminor); 32 30 struct device* dev; /* for dev_dbg() support, set in init */